Skip to content

Clear stale Incipit status when actions appear - #21

Merged
readwrightexecute merged 2 commits into
masterfrom
fix/incipit-clear-stale-status
Oct 14, 2026
Merged

readwrightexecute merged 2 commits into
masterfrom
fix/incipit-clear-stale-status

Conversation

@readwrightexecute

@readwrightexecute readwrightexecute commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • clear the Step 3 status bar out-of-band when completed action buttons render
  • prevent section_card.html from nesting a second #status-bar inside the #step3-actions OOB payload
  • add route coverage asserting the last-section poll response contains exactly one #status-bar

Tests

  • manual Jinja render check: section-card OOB response contains one id="status-bar" and includes step3-actions
  • IDE lints: no errors on edited files
  • not run: pytest / python3 -m pytest tests/test_routes.py because pytest is not installed in this shell

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 000119f. Configure here.

Comment thread webapp/app/templates/partials/step3_actions.html
@readwrightexecute
readwrightexecute marked this pull request as ready for review October 14, 2026 18:28

@readwrightexecute readwrightexecute left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@readwrightexecute Nice, tight fix for the stale status bar. I verified both halves of the change end to end: the /step3-actions route now emits the out-of-band clear for #status-bar (via the new status_oob default) whenever every section is terminal, which covers the job_done-only path where no section-card poll ever runs; and the {% with status_oob=false %} guard in section_card.html correctly keeps the terminal-card branch from double-emitting the same OOB swap (it would have been the direct opposite of the bug being fixed, so this was the right call). The sections-fragment group refetch is unaffected — oob is not passed there, so the clear doesn't leak into the full-list swap. I ran the full webapp suite locally (248 passed, 1 xfail, coverage gate green) and rendered the new and unchanged include paths directly to confirm #status-bar appears exactly once per OOB response. Both new tests pin the exact behavior the PR targets, including the count == 1 duplicate-swap assertion. Ship it — this is a clean, well-scoped fix.

🔁 Powered by Looper · runner=reviewer · agent=pi · An autonomous AI dev team for your GitHub repos.

@readwrightexecute
readwrightexecute merged commit da93409 into master Oct 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant