Repository navigation
[perf] Check method name before type inference in PHPUnit test-case call guard - #807
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TestsNodeAnalyzer::isPHPUnitMethodCallNames()is the gate used by ~25 assert rules (every rule subscribed toMethodCall/StaticCall). It ranNodeTypeResolver::getType()on the caller first and only then compared the method name, so the expensive type inference ran on every method call in a file - including the overwhelming majority that are notassert*calls and bail on the name anyway.This reorders the guard to compare the cheap method name first; a non-matching call now bails before any
getType().Numbers
Micro bench (
bench/phpunit_testcase_call_guard_bench.php, shipped with this PR),AssertInstanceOfComparisonRector::refactor()driven over 300 non-assert method calls, 200 repeats, CPU time (user+sys):~1.8x on the common bail path. Behaviour is unchanged - both conditions are still ANDed, only the order flips.
Full test suite stays green (685 tests).