Repository navigation
[perf] Only process catch stmts PHPStan skipped in PHPStanNodeScopeResolver, run decorating visitors once - #8738
Merged
Merged
Conversation
…solver, run decorating visitors once
Member
Author
|
All green 🎉 @TomasVotruba I am merging it ;) |
Member
|
Nice work 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
Catch_node made the resolver call the wholeprocessNodes()again on that catch block's body.PHPStan already walks catch bodies itself with a more precise scope, right after the callback, and overwrites the result.
The recursion also re-ran the decorating node visitors, so the work doubled at each nesting level.
Here the benchmark by run script:
bench/php_stan_node_scope_resolver_catch_bench.phpmainCPU