Repository navigation
[Transform] Deprecate StaticCallToMethodCallRector as risky constructor injection, never used - #8759
Merged
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
October 21, 2026 22:42
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
StaticCallToMethodCallRector.This generic configurable rule turns a static call into a service method call by injecting the service through the constructor. That is risky - the service may not belong in the class, the constructor may be unsuitable for injection, and the method signature rarely matches. It is a legacy rule that fits few real cases.
Following the same path as the already deprecated sibling
FuncCallToMethodCallRector, downstream users should write a custom rule for their exact project case instead.Changes:
DeprecatedInterface+@deprecated, gutrefactor()to throwFuncCallStaticCallToMethodCallAnalyzer,TypeProvidingExprFromClassResolver,PropertyFetchFactoryand the unusedClassDependencyManipulator::hasFinalParentConstructor()StaticCallToMethodCallvalue object (@api) for existing configs