Skip to content

[Transform] Deprecate ArrayDimFetchToMethodCallRector as too niche and able to create invalid calls - #8762

Merged
TomasVotruba merged 2 commits into
mainfrom
worktree-deprecate-array-dim-fetch-to-method-call
Oct 22, 2026
Merged

TomasVotruba merged 2 commits into
mainfrom
worktree-deprecate-array-dim-fetch-to-method-call

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

This rule is too niche, never used in practice, and can produce invalid method calls on objects that lack the configured get/set/has/unset methods.

Use a specific, targeted rule instead.

Rule is gutted to throw on refactor() and marked @deprecated + DeprecatedInterface, following the existing deprecation pattern. Its tests, config value object, and enum are removed.

@TomasVotruba
TomasVotruba merged commit 959fac4 into main Oct 22, 2026
48 of 49 checks passed
@TomasVotruba
TomasVotruba deleted the worktree-deprecate-array-dim-fetch-to-method-call branch October 22, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants