Repository navigation
[Php83] Deprecate AddOverrideAttributeToOverriddenMethodsRector as never used and not part of any set - #8773
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-deprecate-add-override-attribute
branch
from
October 22, 2026 11:44
d2d0ab0 to
3e70d0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is never used in any set and requires careful per-project context to decide which methods truly override a parent.
Adding the
#[\Override]attribute is a decision best made explicitly on the methods that override, based on project requirements, so this rule is deprecated here.Follows the deprecation pattern of #8768, #8770, etc.