Repository navigation
[dx] Add OrderedRectorInterface to order dependent rules in a single pass - #8846
Merged
Merged
Conversation
A rule implementing OrderedRectorInterface declares precededRule(), the rule that must run before it. RectorRegistry topologically sorts active rules so each dependent rule runs after its predecessor within one file pass, instead of relying on repeated FileProcessor passes to converge.
TomasVotruba
force-pushed
the
tv-ordered-rector-interface
branch
from
October 26, 2026 10:40
e3441cd to
0d3fa42
Compare
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Rules whose output feeds another rule can require more than one pass over a file to converge, because the dependent rule only sees the change on the next pass.
What
OrderedRectorInterfacewithprecededRule(): class-string<RectorInterface>- the rule that must run before this one.RectorRegistry::prepareRectors()topologically sorts active rules so each rule runs after its declared predecessor, within a single pass. Stable order, throws on a cycle. No-op when no rule implements the interface.RectorRegistryTest.