Repository navigation
[CI] Run the test suite with PHPStan Turbo - #8848
Closed
SanderMuller wants to merge 1 commit into
Closed
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
The tests job loads the PHPStan Turbo extension from php.ini, so the fastunit workers and the processes that the tests start all get it. tests/bootstrap.php activates Turbo before preload.php when the extension is loaded. Without the extension nothing changes.
Member
|
Thanks for suggestion. I'd prefer to keep tests as simple as possible, for maintenance and decoupling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests job now loads PHPStan Turbo from php.ini. Every PHP process of the suite gets it: the fast-unit workers, the separate-process test and the
bin/rectorruns intests/Bin.tests/bootstrap.phpactivates Turbo beforepreload.phpwhen the extension is loaded. Without the extension, nothing changes, so local runs work as before.Measured on my fork with this php.ini step, 5 interleaved rounds per job, medians (https://github.com/SanderMuller/rector-src/actions/runs/40309968255):
All runs passed, and Turbo was active in every test process.