fix(release): preserve tagged release records - #770
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44dfe3a5c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if catalog_source_ref is None: | ||
| catalog_source_ref = local_tag_target(repo_root, source_tag) |
There was a problem hiding this comment.
In a shallow or tagless checkout, local_tag_target() returns None, so this path silently validates the historical v0.21.0 manifest against the current working-tree catalog. The corrected beta-32 manifest records digest f5523e…, while the current catalog is 7a8130…, causing both registry-release validate and the newly added copied-manifest test to fail when v0.21.0 is unavailable; the full-history CI checkout masks this non-hermetic behavior. Resolve the immutable source independently of ambient tags, or report the missing tag explicitly instead of falling back to current bytes.
AGENTS.md reference: AGENTS.md:L261-L268
Useful? React with 👍 / 👎.
| identifier_catalog: | ||
| path: products/identifiers/generated/catalog.v1.json | ||
| sha256: 7a8130406862922a1c52f81a43577446713ab10ffe76b49179946ad861af3ac9 | ||
| sha256: f5523ec180e3c3d18f7f18a1704d3932e84a66f03ead0e9124d3c6d366aa20f0 |
There was a problem hiding this comment.
The reviewed commit has no Signed-off-by trailer, although the repository's root AGENTS.md requires every commit to carry a DCO sign-off. Recreate this commit with git commit -s before merging so it satisfies the repository's contribution policy.
AGENTS.md reference: AGENTS.md:L272-L275
Useful? React with 👍 / 👎.
| @@ -34,8 +34,6 @@ Documentation updates for the v0.21.0 beta-32 release: | |||
| reviewed release-image definitions under `release/docker/`. | |||
There was a problem hiding this comment.
This commit changes both release/ and docs/site/, while the root AGENTS.md requires each change to remain scoped to one owning area. Move the public changelog edit into a separate docs-site change from the release tooling, manifest, and release-note corrections.
AGENTS.md reference: AGENTS.md:L280-L282
Useful? React with 👍 / 👎.
1 participant
Summary
This is a release-record correctness fix and is intentionally separate from v0.22.0/beta-33 preparation.
Verification
release/scripts/registry-release validate-currentrelease/scripts/registry-release validate release/manifests/registry-stack-beta-32.yaml/private/tmprelease/scripts/registry-release validate-docsetspython3 -m unittest release/scripts/test_registry_release.py release/scripts/test_registry_release_plans.py(81 tests)git diff --check