Repository navigation
fix: omit JSON bodies on GET requests - #301
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only SDK methods currently construct requests with
params={}; both request implementations forward that asjson={}. Consequently, Requests and HTTPX encode a JSON body and Content-Type on GET requests such asEmails.get()andEmails.list(), including paginated reads whose parameters are already in the URL.Pass no JSON body for GET, preserving existing JSON serialization for writes. This aligns read requests with the API specification and other SDKs and avoids unnecessary GET payloads. This report does not claim a production Resend request currently fails because of the body.
Validation:
git diff --checkpass.References:
Summary by cubic
Stops GET requests from sending a JSON body or Content-Type header, aligning read calls like
Emails.get()andEmails.list()with the API specification and other SDKs. POST writes keep their existing JSON serialization.params={}asjson={}, so Requests and HTTPX encoded an empty JSON payload on every read.Written for commit 0f4e10c. Summary will update on new commits.