Repository navigation
Alert menu redesign, LOG_WIDTH everywhere, button code consolidated - #47
Merged
Merged
Conversation
…ngs are just their emojis Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
Settings stays the gear alone. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…e and all The crossed-out bell under an alert lists just that type and "Unsubscribe from all" (no Other menu). The gear stays. The /alerts message keeps both menus. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
A WARN or an ERROR is cut too, and so are the startup "Keeping warm:" and "Alerts:" lists (the WHOLE marker is gone). Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…ll menus Under an alert (private chats) a 🔊 / 🔇 button turns that type's notification sound on or off. The gear and its sound menus are only in /alerts. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…nd toggle Under an alert, a single ⚙️ opens 🔔 Alert and, while the alert is on and in a private chat, 🔊 Sound. Each is struck through while off, and the menu stays open after a toggle. /alerts keeps its full menus; the Other lists are gone. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…rough toggles with Back Each opens the full list of alert types (alerts on or off in the chat; notification sound on or off, private chats only) with a Back button, and the other is hidden meanwhile. The strikethrough toggles, here and in the individual alert's gear menu, no longer carry emojis. Sub, Unsub and Settings are gone. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
With every alert off there is no Sound button. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…tton stays Each list shows its own button (open) above it, with the other hidden; a green tick marks what is on, a red cross what is off. An alert that is off is not in the Sound list at all. The individual alert's gear menu keeps its strikethrough toggles. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
… red one The tick and the cross stay for a client that doesn't draw button colours. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
The individual alert's Alert and Sound toggles and the irrigation Alerts menu's battery and pause toggles now show their state as /alerts does (a shared toggle_button): ✅ on a green button while on, ❌ on a red one while off. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…gh when off Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
… the list Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…d red when off No green anywhere: a toggle that is on is an ordinary button, one that is off is red with its name struck through. This covers /alerts, the individual alert's menu and the irrigation Alerts options. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
…, no legacy lib/buttons.py is the one home for button(), opener() (the ▸/▾ menu button) and toggle_button() (its data is a function of what a press sets), used by the alert, irrigation, period and report menus. In lib/alerts/menu.py the callback data is built and read in one place (Press, parse), keyboard() is only /alerts and alert_keyboard() only the bell under an alert (internal name "bell", was "gear"), and Bot.on_alert_button reads a Press instead of splitting the data. Dropped: the legacy sections of earlier menus, al:noop, the al:on|off:all branch and the Notifier's unused kinds. Every keyboard in a 407-state matrix is identical to before (apart from gear -> bell in the data). Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
Owner
Author
|
Generated by Claude Code |
Yesterday's last readings are settled only some hours after local midnight (store.horizon), so the wind rose reads two ranges, not one, between 00:00 and then; and a window of the last 3 hours reaches back into yesterday, which memory does not hold. The tests now allow two ranges and ask for the readings since local midnight when it is earlier than 3 hours ago. The bot's code was right. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WBwHofjb1g9onaYRdLZMbf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alerts
/alertshas two buttons, 🔔 Alerts and (private chats) 🔊 Sound. Each opens a list of alert types as toggles, with its own button kept above the list (press it to close) and the other hidden. Sound lists only the types that are on.Logs
LOG_WIDTHapplies to every log line, whatever its level (aWARNorERRORis cut too).Keeping warm:andAlerts:lists are one line each, no wrapping.Cleanup
lib/buttons.py(button,opener,toggle_button); alert callback data is built and read in one place (Press,parseinlib/alerts/menu.py);keyboard()is only/alerts,alert_keyboard()only the bell. Every keyboard (407 states) renders as before./alertsmessages sent before these menus stop working (the stale-button toast).Checks
python -m pytest -qandpython scripts/eval_prompts.py(87 of 87). Two Ecowitt tests fail around local midnight (they fail onmaintoo at that hour).Generated by Claude Code