Skip to content

/ratio, jobs Edit selection, Slack/Discord fixes, startup and log changes - #54

Merged
robdevops merged 26 commits into
mainfrom
claude/kind-newton-ad0z2q
Oct 21, 2026
Merged

/ratio, jobs Edit selection, Slack/Discord fixes, startup and log changes#54
robdevops merged 26 commits into
mainfrom
claude/kind-newton-ad0z2q

Conversation

@robdevops

@robdevops robdevops commented Oct 21, 2026

Copy link
Copy Markdown
Owner

What this PR holds

Every commit on the work branch since #52, grouped:

Commands and charts

  • /ratio [SYMBOL] [forward|current|peg] [top|bottom|negative|reverse] replaces /pe and /peg (both still work typed); .pe takes trailing/current.
  • A bar chart with a single bar is skipped: the report goes as text (period buttons kept).
  • Telegram keyboard: .pe and .jobs buttons, sorted.
  • Treemap Grouped by menu: the last button reads OK.

.jobs menu

  • Edit selects jobs (red) and changes nothing until OK; OK shows only when the selection differs from the jobs as they are; Delete only with a selection; Select all / Select none; Cancel; OK and Delete change a chat's jobs in one change.
  • Top level has no page buttons (what fits, and "…and N more"); Run becomes Run...

Slack

  • Manifest: --only, leaves out /who (and /help handling), docs on why both manifests must not be installed.
  • Log says why a press uploads its chart; the not-ready-yet retry is worded plainly.

Discord

  • A refused interaction's token stays out of the log; the endpoint check that passes is logged; a refused update is one warning line (body at debug).
  • An interaction webhook answering Unknown Webhook (10015) is retried after short waits.

Logging and docs

  • Startup logs networks: discord (push), slack (pull), …; the schedule line after a change reads schedule: <chat>: updated.
  • doc/classes.md, and doc updates for each change above.

Test plan

  • .venv/bin/python -m unittest discover -s tests -b (648 tests, offline)
  • CI on 3.x and 3.13.5, and the docker job

Generated by Claude Code

claude and others added 26 commits October 19, 2026 07:49
@claude
.pe takes trailing (or current) for the trailing P/E
e1725e0 
.pe [SYMBOL|top|bottom|negative] [trailing]: with trailing or current,
beside top, bottom or negative in either order, the list is by the
trailing P/E, of earnings reported, not the forward one.

- Command gets options, a second word read beside its keyword (Args.option),
  so ".pe bottom current" has both; suggest offers it.
- A trailing P/E is no analysts' estimate, so its list takes every stock
  and its chart's subtitle has the date alone; the forward P/E and the PEG
  still need min_analysts.
- Usage lines, doc/commands.md and util/record_outputs.py's list follow.

record_outputs: the usage text (.help, /start, .jobs add) and the two new
steps differ.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
/ratio replaces /pe and /peg: the ratio, then its end, as optional words
7cbde4f 
.ratio [SYMBOL] [forward|current|peg] [top|bottom|negative|reverse]

- The forward P/E by default; current (or trailing) is the trailing P/E,
  peg the PEG. The end is top (by default), bottom or reverse (the
  highest first) or negative, in either order with the ratio.
- .pe, .forward pe, .fpe and .peg stay as names of it, .peg's the PEG, so
  typed commands and jobs stored under pe or peg run as before; .help,
  the slash command menus, the keyboard button and the Add menu list
  ratio alone.
- A forward P/E and a PEG still need min_analysts analysts; a trailing
  P/E, of earnings reported, takes every stock.
- Command.options (Args.option) is the second optional word that .pe
  trailing added; here it is the ratio, and the keyword the end.

record_outputs: the usage text (.help, /start, .jobs add, the Add menu)
and the three new .ratio steps differ; .pe and .peg runs are identical.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
doc/classes.md: every class, by what it is for
eea3e1c 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
doc/slack.md: say why both manifests must not be installed
e610a5c 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Slack manifest leaves out /help, which Slack keeps for itself
0a9cf17 
Slack refused the manifest ("The slash command has an invalid name") at
/help, one of its own commands. The manifest names every slash command of
.help but that one; .help and @FinBot help still answer.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
slack_manifest.py --only NAMES: a manifest with just those slash comm…
d2e9d1b 
…ands

To find which slash command Slack refuses when it rejects a manifest.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Slack manifest leaves out /who, which Slack keeps for itself; /help i…
4665649 
…s back

Slack refused the manifest at /who ("invalid name"), found with --only.
/help was never the problem, so the manifest names it again; .who SYMBOL
and @FinBot who SYMBOL still answer.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
doc/slack.md: the manifest's mode comes from --url, not from finbot.env
a167756 
The text implied util/slack_manifest.py reads slackOutgoingWebhook, which
the tool never does (finbot.env is readable by root alone). It is the
tool's --url that picks push mode; finbot.env picks finbot's own side.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Slack: say why a press uploads its chart, and word the not-ready-yet …
030a9a1 
…retry plainly

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
A bar chart of one bar is skipped: the report goes as text
5905a37 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
jobs > Edit: Disable all button; /jobs top level has no page buttons
fb1cac0 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
jobs > Edit: Cancel button
5a52ad0 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
schedule log line after a change names the chat (network and id)
ef25037 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
jobs > Edit: Select all / Select none, Delete and OK only with a sele…
8c99820 
…ction; Run becomes Run...

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
jobs > Edit selects jobs and changes nothing until OK, which shows on…
36a62de 
…ly when the selection differs; schedule log says '<chat>: updated'

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
jobs > Edit: OK and Delete change a chat's jobs in one change, so the…
668921a 
… log says 'updated' once

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Startup logs the enabled networks and how each reaches finbot (push o…
05dce2c 
…r pull)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Discord: a refused interaction's token stays out of the log; the sign…
30a07eb 
…ature warning explains Discord's deliberate bad probe

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Discord: log the endpoint check that passes; a refused update is one …
8603f6e 
…warning line, its body at debug

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Keyboard: .pe and .jobs buttons, sorted; /peg is a slash command of i…
85920e4 
…ts own

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
No /peg slash command: .peg and /peg are typed names of /ratio peg, a…
d85ad4e 
…s before

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Discord: an interaction's webhook answering Unknown Webhook (10015) i…
eec42a3 
…s tried again after short waits

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Treemap grouping menu: Done, as its last button
45f36ab 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
Treemap grouping menu: the last button reads OK
b759534 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@claude
CLAUDE.md: drop the pull-request rules, so Claude Code's own PR and C…
24742c3 
…I controls apply

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
@robdevops
Merge branch 'main' into claude/kind-newton-ad0z2q
c067548
@robdevops
robdevops merged commit ac5ea8f into main Oct 21, 2026
4 checks passed
@robdevops robdevops mentioned this pull request Oct 21, 2026
Merged
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robdevops @claude