Repository navigation
Revert #36, log multi-part xAI messages, bring in SQLite tweaks - #37
Merged
Merged
Conversation
New databases get the compact table; tools/period_cache_without_rowid.py converts an existing one. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
…evops fork Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
…eplies "at close" matched no gate keyword, so the model got the no-tools prompt and answered from the transcript, opening with "(no tool calls needed)". Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
…uestions" This reverts commit 7b22d53.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
…heisenberg-pz23nq # Conflicts: # lib/telegram/handlers.py
…heisenberg-pz23nq
…ssages Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
…ionate-heisenberg-pz23nq
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014k4kywyN5dAo39izUPvxbw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#36 (session words, news prompt, forced search for "at close"-style chat questions) was built on a wrong diagnosis. The bad replies it targeted ("(no tool calls needed)", a draft glued to the final answer) came from a build older than
main:claude/nextstill joins every xAI message (resp.output_text), which #34 already fixed onmain. Nothing shows a problem in currentmain, so this undoes #36.What
SESSION_WORDS/is_session_questioninlib/llm/gate.py, thesessionflag inlib/prompts.pyandlib/telegram/handlers.py, the forcedmust_search, and their tests. The tree matchesmainfrom before Force a news search for trading-session questions #36.lib/llm/xai.py: adds one log line,xAI message had N text parts (...), when a message has several non-empty text parts. Behaviour is unchanged (parts are still joined); the line only tells us whether that case happens. Test included.281c13ffromclaude/next: SQLitesynchronous=NORMALunder WAL andperiod_cache WITHOUT ROWID(lib/store.py,tools/period_cache_without_rowid.py, tests,CLAUDE.md).claude/nextitself is untouched.Testing
make checkon Python 3.13.5: ruff clean, 292 tests pass. Not run against a live model.Generated by Claude Code