Skip to content

[io] test for renaming with unversioned classes - #18666

Draft
ferdymercury wants to merge 5 commits into
root-project:masterfrom
ferdymercury:renamtest
Draft

[io] test for renaming with unversioned classes#18666
ferdymercury wants to merge 5 commits into
root-project:masterfrom
ferdymercury:renamtest

Conversation

@ferdymercury

@ferdymercury ferdymercury commented May 9, 2025

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

Test for #14491
Closes #14491

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Comment thread roottest/root/io/evolution/versions/execROOT14491.cxx Outdated
@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 5h 51m 23s ⏱️
 3 837 tests  3 835 ✅ 0 💤 2 ❌
71 609 runs  71 598 ✅ 8 💤 3 ❌

For more details on these failures, see this check.

Results for commit c7df9fe.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury added this to the 6.38.00 milestone May 15, 2025
@ferdymercury
ferdymercury requested review from jblomer and pcanal August 12, 2025 09:17
@ferdymercury
ferdymercury requested a review from linev August 26, 2025 20:46
@linev

linev commented Aug 27, 2025

Copy link
Copy Markdown
Member

Instead providing root file I would add writedata.C macro and execute it.
So one can clearly see that kind of data is produced.

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

Instead providing root file I would add writedata.C macro and execute it.
So one can clearly see that kind of data is produced.

Thanks, good idea. Could you verify that I set the FIXTURES flag correctly? Since I am not used to those yet.

@ferdymercury
ferdymercury force-pushed the renamtest branch 2 times, most recently from 2e29f59 to 2ea8e5a Compare August 27, 2025 08:28
@linev

linev commented Aug 27, 2025

Copy link
Copy Markdown
Member

Fixtures configured correctly.
I let @pcanal approve PR.

@ferdymercury

Copy link
Copy Markdown
Collaborator Author

It seems it only fails on Windows. No idea why...

@linev

linev commented Aug 27, 2025

Copy link
Copy Markdown
Member

It seems it only fails on Windows. No idea why...

Looks like difference in file content.
May be some variables not initialized when file is created.

Comment thread roottest/root/io/evolution/versions/ROOT14491readdata.cxx Outdated
Comment thread roottest/root/io/evolution/versions/ROOT14491simpleread.cxx Outdated
Comment thread roottest/root/io/evolution/versions/ROOT14491writedata.cxx Outdated
@ferdymercury
ferdymercury marked this pull request as draft October 28, 2025 19:41
@ferdymercury ferdymercury removed this from the 6.38.00 milestone Oct 29, 2025
@ferdymercury

Copy link
Copy Markdown
Collaborator Author

@bellenot do you have by chance an educated guess of what could be failing in Windows? such as an integer type having different widths on each platform or so.

@bellenot

bellenot commented Dec 8, 2025

Copy link
Copy Markdown
Member

@ferdymercury I don't see anything obvious, but I'll check...
The test output & diff is:

  -- BEGIN TEST OUTPUT --
  
  Processing C:/ROOT-CI/src/roottest/root/io/evolution/versions/ROOT14491readdata.cxx+...
  ***********************************
  *    Row   * Instance * seg_split *
  ***********************************
  dups 0
  copy 0
  dups 1
  copy 1
  *        0 *        0 *         0 *
  ***********************************
  dups 0
  copy 0
  dups 1
  copy 1
  ***********************************
  *    Row   * Instance * seg_unspl *
  ***********************************
  dups 0
  copy 0
  dups 1
  copy 2
  dups 0
  copy 0
  dups 1
  copy 3
  *        0 *        0 *         0 *
  ***********************************
  (int) 0
  
  -- END TEST OUTPUT --
  -- BEGIN OUTDIFF OUTPUT --
  --- C:/ROOT-CI/src/roottest/root/io/evolution/versions/ROOT14491readdata.ref	Mon Dec  8 12:12:20 2025
  +++ C:/ROOT-CI/build/roottest/root/io/evolution/versions/ROOT14491readdata.log	Mon Dec  8 13:54:41 2025
  @@ -23,6 +23,6 @@
   copy 0
   dups 1
   copy 3
  -*        0 *        0 *         1 *
  +*        0 *        0 *         0 *
   ***********************************
   (int) 0
  
  -- END OUTDIFF OUTPUT --

So maybe @pcanal has an idea, before I start debugging...

to prevent padding issues on Windows
Google-AI assisted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion StreamerInfo not properly found if classes are unversioned.

5 participants