Object auto registration: Next steps - #22817
Merged
Merged
Conversation
Test Results 23 files 23 suites 3d 14h 7m 19s ⏱️ Results for commit a733fcf. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
2 times, most recently
from
July 22, 2026 17:34
0f0f681 to
08db558
Compare
This was referenced Jul 23, 2026
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
4 times, most recently
from
July 28, 2026 07:30
4b38b4d to
0509610
Compare
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
2 times, most recently
from
July 29, 2026 11:39
84d8847 to
2b3620f
Compare
hageboeck
commented
Jul 29, 2026
hageboeck
marked this pull request as ready for review
July 29, 2026 11:40
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
from
July 29, 2026 11:46
2b3620f to
fe3ae12
Compare
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
from
August 3, 2026 11:11
fe3ae12 to
4830ae7
Compare
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
from
August 4, 2026 07:09
4830ae7 to
62e7c38
Compare
guitargeek
approved these changes
Aug 4, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Nothing controversial to see here. Thanks for the work!
TEntryList and its derived classes will from here on only register themselves to gDirectory when the thread-local auto-registration is enabled.
Explain that defaults can be set using .rootrc or using environment variables, and how to do this from within the program.
Clang-format enforces lines breaks, even if the lines weren't touched in git-clang-format mode.
hageboeck
force-pushed
the
AutoReg_GlobalDefault
branch
from
August 4, 2026 16:05
62e7c38 to
a733fcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on disabling auto registration of TEventList / TEntryList.
By now, ROOT has already been prepared to work with auto-registration on and off for TEntryList/TEventList, so what's left is to disable their auto-registration and explain what changed. This is done here.
Preparatory work
Typically, when working towards disabling the auto-registration of certain classes, there is an opportunity to clean up code and fix tangentially related issues that are encountered on the way. Like for the last auto-registration PR (#18083), these will be split off into smaller chunks that are going to be merged first:
Note that to uncover potential auto-registration problems, ROOT is in ROOT 7 mode while this PR is in draft mode. The commit that globally enables ROOT 7 mode will be removed before merging the actual work for TEventList / TEntryList.
TODOs: