Skip to content

fix TStreamerLoop counter offset in member-wise streaming - #22901

Open
tamasgal wants to merge 9 commits into
root-project:masterfrom
tamasgal:issue-22895
Open

fix TStreamerLoop counter offset in member-wise streaming#22901
tamasgal wants to merge 9 commits into
root-project:masterfrom
tamasgal:issue-22895

Conversation

@tamasgal

Copy link
Copy Markdown

This Pull request:

Fixes TStreamerLoop counter offset in member-wise streaming and adds a regression test.

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #22895

@dpiparo

dpiparo commented Jul 24, 2026

Copy link
Copy Markdown
Member

Thanks for this proposal. Just to double-check: have you had a moment to give a look to ROOT's contributing policy? https://github.com/root-project/root/blob/master/CONTRIBUTING.md#ai-assisted-coding-disclosure

@tamasgal

Copy link
Copy Markdown
Author

no LLM involved, only tooling were clang-format and my ROOT binary reverse engineering skills from the past years ;)

Comment thread io/io/test/CMakeLists.txt Outdated
Comment thread io/io/test/CMakeLists.txt Outdated
Comment thread io/io/test/TStreamerLoopMemberwise.cxx Outdated
Comment thread io/io/src/TStreamerInfoActions.cxx Outdated
Comment thread io/io/src/TStreamerInfoActions.cxx Outdated
@tamasgal

Copy link
Copy Markdown
Author

many thanks for the comments! Meanwhile me and my colleague (with more that two decades of ROOT experience and the original author of our I/O library) are still doing tests and found other issues, so let me put this on hold for now.

I'll implement your suggestions of course but I fear it's not the whole story ;(

@tamasgal

Copy link
Copy Markdown
Author

as mentioned in the upstream issue, we verified the patch also with the extensive high-level test suite, everything looks fine from our side :)

@dpiparo

dpiparo commented Jul 26, 2026

Copy link
Copy Markdown
Member

no LLM involved, only tooling were clang-format and my ROOT binary reverse engineering skills from the past years ;)

Thanks for the clarification! I restarted the tests with the newly proposed code.

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 19h 51m 15s ⏱️
 3 854 tests  3 854 ✅ 0 💤 0 ❌
75 676 runs  75 676 ✅ 0 💤 0 ❌

Results for commit 600799a.

♻️ This comment has been updated with latest results.

@tamasgal

Copy link
Copy Markdown
Author

could someone please kick off the tests? i messed up the order in the tests CMakeLists but it's fixed now ;)

@dpiparo dpiparo added the clean build Ask CI to do non-incremental build on PR label Aug 4, 2026
@dpiparo dpiparo closed this Aug 4, 2026
@dpiparo dpiparo reopened this Aug 4, 2026
@dpiparo

dpiparo commented Aug 4, 2026

Copy link
Copy Markdown
Member

@pcanal, I restarted the ci selecting clean-build to get rid of some artifacts. The PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I/O regression since 6.36: member-wise reading/writing of a variable-size array in a base class uses the wrong counter offset

5 participants