[RF] Make RooMultiPdf::generate() error out when the index is requested - #22990
Open
guitargeek wants to merge 1 commit into
Open
[RF] Make RooMultiPdf::generate() error out when the index is requested#22990guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
The index category of a RooMultiPdf selects between alternative hypotheses for the observables (as used in the discrete profiling method), unlike the index category of a RooSimultaneous, which is a genuine observable that partitions the data. Component yields express "expected count if hypothesis k were true", not partition sizes, so there is no well-defined prior probability over the index that could be used to sample it, and the previous fallback to the generic accept-reject generator produced an arbitrary, unintended ~uniform split over hypotheses. Add a RooMultiPdf::genContext() override that throws if the index category is among the requested generation variables, and points users at fixing the index (e.g. via RooCategory::setIndex()) and generating from the resulting single-component pdf instead, which is also how the discrete profiling method is actually used in practice. Closes root-project#22916.
Test Results 23 files 23 suites 3d 13h 58m 9s ⏱️ For more details on these failures, see this check. Results for commit 970f0ff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index category of a RooMultiPdf selects between alternative hypotheses for the observables (as used in the discrete profiling method), unlike the index category of a RooSimultaneous, which is a genuine observable that partitions the data. Component yields express "expected count if hypothesis k were true", not partition sizes, so there is no well-defined prior probability over the index that could be used to sample it, and the previous fallback to the generic accept-reject generator produced an arbitrary, unintended ~uniform split over hypotheses.
Add a RooMultiPdf::genContext() override that throws if the index category is among the requested generation variables, and points users at fixing the index (e.g. via RooCategory::setIndex()) and generating from the resulting single-component pdf instead, which is also how the discrete profiling method is actually used in practice.
Closes #22916.