Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ CMAKE_CXX_FLAGS_DEBUG="-Og -g"
asan=ON
ccache=ON
builtin_vdt=ON
fail-on-missing=ON
minimal=ON
roottest=ON
testing=ON
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
ccache=ON
builtin_vdt=ON
fail-on-missing=ON
minimal=ON
roottest=ON
testing=ON
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/global.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ davix=ON
dcache=OFF
dev=OFF
distcc=OFF
fail-on-missing=ON
fcgi=OFF
fftw3=ON
fitsio=ON
Expand Down
1 change: 1 addition & 0 deletions README/ReleaseNotes/v642/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ The following people have contributed to this new version:
## Deprecation and Removal

* The build options `vc`, `veccore`, `builtin_vc`, `builtin_veccore` and `rpath` that were deprecated are now removed and will result in configuration errors if used.
* The option `fail-on-missing` is deprected in 6.42 (it has no effect, now the behavior will be as if it was always ON), and will be removed in 6.44.
* The method `RooRealVar::removeRange()` and the corresponding method in `RooErrorVar` that were deprecated in ROOT 6.40 are now removed.
* The overloads of `RooAbsReal::createChi2()` and `RooAbsReal::chi2FitTo()` that take unbinned **RooDataSet** data objects were deprecated in ROOT 6.40 and are now removed.
* The **RooStats::HybridPlot** class and the related **HybridResult::GetPlot** method were deprecated in ROOT 6.40 and are now removed.
Expand Down
4 changes: 2 additions & 2 deletions cmake/modules/CheckCompiler.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ if(fortran)
enable_language(Fortran)
endif()
endif()
if(NOT CMAKE_Fortran_COMPILER AND fail-on-missing)
message(FATAL_ERROR "No Fortran compiler found. Please make sure it's installed, or disable ROOT's Fortran features with '-Dfortran=OFF' (or set '-Dfail-on-missing=OFF' to automatically disable features with missing requirements)")
if(NOT CMAKE_Fortran_COMPILER)
message(SEND_ERROR "No Fortran compiler found. Please make sure it's installed, or disable ROOT's Fortran features with '-Dfortran=OFF'")
endif()
else()
set(CMAKE_Fortran_COMPILER CMAKE_Fortran_COMPILER-NOTFOUND)
Expand Down
8 changes: 7 additions & 1 deletion cmake/modules/RootBuildOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ ROOT_BUILD_OPTION(xrootd ON "Enable support for XRootD file server and client")

option(all "Enable all optional components by default" OFF)
option(clingtest "Enable cling tests (Note: that this makes llvm/clang symbols visible in libCling)" OFF)
option(fail-on-missing "Fail at configure time if a required package cannot be found" OFF)
option(gminimal "Enable only required options by default, but include X11/Cocoa" OFF)
option(minimal "Enable only required options by default" OFF)
option(rootbench "Build rootbench if rootbench exists in root or if it is a sibling directory (implies testing=ON)" OFF)
Expand Down Expand Up @@ -389,6 +388,13 @@ foreach(opt r)
endif()
endforeach()

if(DEFINED fail-on-missing)
message(DEPRECATION ">>> Option 'fail-on-missing' is deprecated and ignored."
" ROOT now behaves as if fail-on-missing was always ON."
" Using this option will result in configuration errors in ROOT 6.44."
"") # empty line at the end to make the deprecation message more visible
endif()

foreach(opt minuit2_mpi)
if(${opt})
message(WARNING "The option '${opt}' can only be used to minimise thread-safe functions in Minuit2. It cannot be used for Histogram/Graph fitting and for RooFit. If you want to use Minuit2 with MPI support, it is better to build Minuit2 as a standalone library.")
Expand Down
Loading