Skip to content

Cleaned changes #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhigyan-ach wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cleaned changes #288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a183b5c
Branch to Review
May 28, 2024
580307f
Cleaned Branch
Jun 10, 2024
60fa2c5
Changes to Binned Benchmarks Script
Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleaned Branch
  • Loading branch information
Abhigyan Acherjee Abhigyan Acherjee
Abhigyan Acherjee authored and Abhigyan Acherjee committed Jun 10, 2024
commit 580307fa8b71be393340fa653d8eb125cc194a78
12 changes: 6 additions & 6 deletions root/roofit/roofit/RooFitBinnedBenchmarks.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,11 +270,11 @@ static void ChanArguments(benchmark::internal::Benchmark *b)
}

// bin scan
//for (int nBins : nBinsVector) {
//for (int nCPU : nCPUVector) {
//b->Args({nChannelsForBinScan, nBins, nCPU});
//}
//}
for (int nBins : nBinsVector) {
for (int nCPU : nCPUVector) {
b->Args({nChannelsForBinScan, nBins, nCPU});
}
}
}

BENCHMARK(BM_RooFit_BinnedTestMigrad)->Apply(ChanArguments)->UseRealTime()->Unit(timeUnit)->Iterations(1);
Expand All @@ -299,7 +299,7 @@ int main(int argc, char **argv)
evalBackend = argv[i + 1];
}
if (i + 2 < argc) {
// Set the evalBackend value from the next command-line argument
// Set the sevalBackend value from the next command-line argument
evalBackend = argv[i + 1];
seeding_only = argv[i + 2];
}
Expand Down