Skip to content

Return nil from Date#<=> for a NaN #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasklemm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return nil from Date#<=> for a NaN #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ source 'https://rubygems.org'
gemspec unless RUBY_ENGINE == 'jruby'

group :development do
gem "bigdecimal"
gem "bundler"
gem "rake"
gem "rake-compiler"
Expand Down
2 changes: 1 addition & 1 deletion ext/date/date_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6920,7 +6920,7 @@ cmp_gen(VALUE self, VALUE other)
get_d1(self);

if (k_numeric_p(other))
return INT2FIX(f_cmp(m_ajd(dat), other));
return rb_funcallv(m_ajd(dat), id_cmp, 1, &other);
else if (k_date_p(other))
return INT2FIX(f_cmp(m_ajd(dat), f_ajd(other)));
return rb_num_coerce_cmp(self, other, id_cmp);
Expand Down
15 changes: 15 additions & 0 deletions test/date/test_date_arith.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,21 @@ def test__compare
DateTime.new(2001,1,17,0,0,0,0,Date::GREGORIAN)))
end

def test__compare_nan
nans = [Float::NAN]
begin
require "bigdecimal"
nans << BigDecimal("NaN")
rescue LoadError
end
d = Date.new(2000,1,1)
nans.each do |nan|
assert_nil(d <=> nan)
assert_equal(false, d == nan)
assert_raise(ArgumentError) { d < nan }
end
end

def test_prev
d = Date.new(2000,1,1)
assert_raise(NoMethodError) do
Expand Down