Repository navigation
test(ci): run the workspace tests on Windows - #87
Needs Human Approval
- Eligibility · Permissive mode · Add a custom policy
- Correctness
Note
More information about how approvability works can be found in our Help Center.
Details
Eligibility
This adds Windows workspace testing and shared Windows path support. An unresolved review concern about mixed canonical-path prefixes affects confinement and could allow harness work inside the caller’s checkout; that isolation question needs resolution.
Additional Thinking
Code
Expands Windows CI to workspace tests, installs checksum-pinned Windows tools, and adds Windows runtime support for folder discovery, canonical paths, manifest separators, stack size, and seal randomness. Shared path helpers reach deployment, confinement, workspace isolation, and user configuration; Unix behavior is largely preserved.
Review Context
Author runewright changes files owned by N4M3Z; ownership alone is not a veto. The sole unresolved external review raises a substantive Windows confinement concern: short and long canonical paths can retain different prefixes. Inspection confirms the cited consumers use starts_with for confinement and checkout exclusion. The concern has no supplied reply addressing it. The configured Macroscope blocking threshold is medium; that independent gate does not resolve this external concern. Both supplied agent results are unknown; no customer prerequisites or guidelines were supplied.
Verdict
The unanswered external concern affects Windows checkout isolation, not merely path presentation: a workspace could be accepted inside the caller's checkout, allowing harness files into its snapshot. A human must resolve whether mixed plain/verbatim canonical paths preserve confinement and checkout exclusion before merging; the review concern is not being re-adjudicated here.
Notes:
@Runewright isn't a code owner for 139 files:
• build.rs (owned by N4M3Z)
• src/lib.rs (owned by N4M3Z)
• Cargo.lock (owned by N4M3Z)
• src/folders.rs (owned by N4M3Z)
• tests/run.rs (owned by N4M3Z)
• Cargo.toml (owned by N4M3Z)
• src/cli/init/tests.rs (owned by N4M3Z)
• src/cli/state.rs (owned by N4M3Z)
• src/cli/policy.rs (owned by N4M3Z)
• src/policy/mod.rs (owned by N4M3Z)
• src/target/mod.rs (owned by N4M3Z)
• tests/target.rs (owned by N4M3Z)
• src/tui/tests.rs (owned by N4M3Z)
• src/cli/find/mod.rs (owned by N4M3Z)
• src/policy/paths.rs (owned by N4M3Z)
• src/target/tests.rs (owned by N4M3Z)
• tests/proof_head.rs (owned by N4M3Z)
• scripts/tool-versions (owned by N4M3Z)
• src/cli/exec/tests.rs (owned by N4M3Z)
• src/cli/run/mod.rs (owned by N4M3Z)
• src/cli/session.rs (owned by N4M3Z)
• tests/hook_policy.rs (owned by N4M3Z)
• src/cli/adopt/tree.rs (owned by N4M3Z)
• src/cli/hook/mod.rs (owned by N4M3Z)
• src/cli/dotrune/git.rs (owned by N4M3Z)
• src/cli/dotrune/mod.rs (owned by N4M3Z)
• src/cli/config/mod.rs (owned by N4M3Z)
• tests/codex_skill_metadata.rs (owned by N4M3Z)
• src/cli/drift/scope.rs (owned by N4M3Z)
• src/cli/interface/mod.rs (owned by N4M3Z)
• tests/session_capture.rs (owned by N4M3Z)
• src/cli/hook/publish.rs (owned by N4M3Z)
• src/cli/queue/ledger.rs (owned by N4M3Z)
• src/cli/update_check.rs (owned by N4M3Z)
• src/cli/mod.rs (owned by N4M3Z)
• src/cli/provenance/scan.rs (owned by N4M3Z)
• src/cli/watchlist/tests.rs (owned by N4M3Z)
• src/services/provenance.rs (owned by N4M3Z)
• src/cli/hook/retire.rs (owned by N4M3Z)
• src/cli/hook/wrap.rs (owned by N4M3Z)
• src/cli/ontology.rs (owned by N4M3Z)
• src/cli/provenance/mod.rs (owned by N4M3Z)
• src/cli/surface/cursor.rs (owned by N4M3Z)
• src/provider/detection.rs (owned by N4M3Z)
• and 95 files omitted
Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.