Repository navigation
Conversation
flash dev mounts QB routes at /<module>/<fn>/runsync when a module defines more than one @endpoint function; /<module>/runsync only exists for single-function modules. The documented paths 404'd. - mixed_workers: cpu_worker -> preprocess_text - text_to_speech: generate_speech, get_voices - autoscaling: README curls, load_test examples, DEFAULT_ENDPOINT Verified against flash dev route listing on runpod-flash 1.20.0. SLS-346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the queue-based (
/runsync) request examples across the READMEs so they work when copy-pasted intoflash dev. Two independent bugs made them fail:inputenvelope (422). QB routes require{"input": {"<function-param-name>": ...}}. The docs showed the raw body. The inner key is the worker function's parameter name (input_data,payload, orprompt), so it varies per example.@Endpointfunction,flash devmounts/<module>/<function>/runsync;/<module>/runsynconly exists for single-function modules. Affected:03_mixed_workers(cpu_worker),01_text_to_speech,01_autoscaling(README curls, load-test examples, andload_test.py'sDEFAULT_ENDPOINT).Also wraps the placeholder payloads in
CLI-REFERENCE.md,CONTRIBUTING.md, anddocs/cli/commands.md, andload_test.py'sDEFAULT_PAYLOAD(the load test previously 422'd on every request).Load-balanced routes (
@endpoint.post/get, e.g./pipeline/classify) take the body directly and are unchanged. Single-function modules (01_hello_world,02_cpu_worker,01_network_volumes,05_volume_warm_cache, mixed_workersgpu_worker) keep/<module>/runsync.Linear: SLS-346
Type of Change
Testing
Run with
flash dev. Runpod Flash is 1.17.0 unless noted.02_cpu_worker/cpu_worker/runsyncCOMPLETED/cpu_worker/cpu_scale_to_zero/runsyncCOMPLETED/cpu_worker/runsync(1.17.0 and 1.20.0)/runsyncroute's OpenAPI request schema requiresinput, the unwrapped payload still 422s, and multi-function routes are still/<module>/<fn>/runsync.flash devprints at startup. All exist.make quality-checkpasses.🤖 Generated with Claude Code