Repository navigation
fix: wait for cold-start jobs and print a runnable curl example after deploy #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justinwlin
wants to merge
13
commits into
main
Choose a base branch
from
fix/sentinel-poll-in-progress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c19b827
fix(sentinel): poll /status when runsync returns before the job finishes
justinwlin 2a448e0
fix(sentinel): ask runsync to return before the client times out
justinwlin 2f42032
fix(deploy): print a curl example the endpoint can actually run
justinwlin 8a09c8b
fix(sentinel): harden polling and the curl example after review
justinwlin 5d467d4
fix(sentinel): retry transient status errors and report failed cancels
justinwlin 00577dc
fix(sentinel): submit with /run when the timeout leaves no room for r…
justinwlin 202baee
fix(sentinel): count queue time from submission and read the last def…
justinwlin d6efc3e
fix(deploy): read the last definition of a redefined class for the cu…
justinwlin 607ab34
fix(sentinel): cap the poll backoff exponent and drop any method rece…
justinwlin 14d6982
fix(deploy): recognize qualified staticmethod decorators in the curl …
justinwlin 715d876
fix(sentinel): raise a RuntimeError naming the job on a 4xx while pol…
justinwlin 9da9066
fix(sentinel): address review: document unbounded polling, wrap non-J…
justinwlin 5bbffa0
fix(cli): correct --python-version help and python_version field desc…
justinwlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low: This help-text fix (and the matching ones in
deploy.pyandserverless.py) is unrelated to cold-start polling and the curl example, and the PR body does not mention it. Add one line under "Change", or split it into its own PR. While here,cli/docs/flash-build.md:31andflash-deploy.md:91still list only 3.10 to 3.12 and say "Overrides per-resourcepython_version"; update them to match.