Skip to content

fix(cli): state runpod-flash deprecation in past tense #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deanq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): state runpod-flash deprecation in past tense #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Flash

> [!WARNING]
> Flash is moving into the Runpod Python SDK 2.0. `runpod-flash` will be deprecated on **October 29, 2026** and will receive no fixes or updates after that date. See the [migration guide](https://docs.runpod.io/sdk/migrate-from-flash).
> Flash has moved into the Runpod Python SDK 2.0. `runpod-flash` was deprecated on **October 29, 2026** and receives no fixes or updates. This repository is archived and read-only. See the [migration guide](https://docs.runpod.io/sdk/migrate-from-flash).
>
> The `flash` CLI and the SDK print this notice once per process. Set `RUNPOD_FLASH_SILENCE_DEPRECATION=1` to silence it (for example, in CI).

Expand Down
10 changes: 5 additions & 5 deletions src/runpod_flash/sunset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Package-level deprecation notice for runpod-flash.

Flash is moving into the Runpod Python SDK 2.0. This module owns the notice
users see before and after the sunset date, shown once per process through
Flash has moved into the Runpod Python SDK 2.0. This module owns the notice
users see once the package is deprecated, shown once per process through
one of two channels:

- the ``flash`` CLI prints it to stderr on every invocation (stdout stays
Expand All @@ -26,9 +26,9 @@
MIGRATION_GUIDE_URL = "https://docs.runpod.io/sdk/migrate-from-flash"

SUNSET_MESSAGE = (
"Flash is moving into the Runpod Python SDK 2.0. runpod-flash will be "
f"deprecated on {SUNSET_DATE} and will receive no fixes or updates after "
f"that date. Migration guide: {MIGRATION_GUIDE_URL}"
"Flash has moved into the Runpod Python SDK 2.0. runpod-flash was "
f"deprecated on {SUNSET_DATE} and receives no fixes or updates. "
f"Migration guide: {MIGRATION_GUIDE_URL}"
)

_WORKER_ENV_VARS = ("RUNPOD_ENDPOINT_ID", "RUNPOD_POD_ID")
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/test_sunset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ def test_message_states_date_no_updates_and_migration_guide(self):
assert "Runpod Python SDK 2.0" in sunset.SUNSET_MESSAGE
assert sunset.MIGRATION_GUIDE_URL in sunset.SUNSET_MESSAGE

def test_message_states_deprecation_in_past_tense(self):
# the final release ships at the sunset date, so the notice must not
# describe the deprecation as upcoming
assert "was deprecated on October 29, 2026" in sunset.SUNSET_MESSAGE
assert "will be" not in sunset.SUNSET_MESSAGE


class TestImportWarning:
def test_public_api_access_emits_future_warning(self):
Expand Down
Loading