Repository navigation
fix(apps): pin requested gpu devices instead of their whole pool - #624
Merged
Merged
Conversation
This was referenced Oct 19, 2026
Endpoints select GPUs by pool, so a device list like ["NVIDIA GeForce RTX 4090", "NVIDIA L4", "NVIDIA RTX A5000"] deployed as ADA_24,AMPERE_24 and workers could land on any device in those pools, including an RTX PRO 6000 MIG 1g.24gb slice the platform added to AMPERE_24. Exclude every other device in each pool selected through a device name with "-<device id>" tokens, as runpod-flash did. Membership comes from the platform's live GPU catalog, because the static pool table lags it (it has no MIG slices); the static table is the fallback when the catalog is unreachable. Pools named directly still allow all devices.
a failed catalog lookup was logged at debug and cached for the process, so pins silently lost exclusions the static table lacks. warn instead, and retry the catalog after a minute.
justinwlin
force-pushed
the
fix/apps-exact-gpu-negations
branch
from
October 20, 2026 15:48
fa8aa2c to
911ea98
Compare
justinwlin
marked this pull request as ready for review
October 20, 2026 15:48
KAJdev
approved these changes
Oct 20, 2026
Promptless documentation updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flash → SDK 2.0 fix stack
Status as of 2026-10-22. 1–5 are merged; 10 is stacked on 9. Hover a link for its status.
mainpeft/accelerateno longer bundledrp flash devdeletes its endpoints when stopped by a signalvol.pathworks on deployed workersrunpod2.0.1 with 2–5 (release PR #594). 2.0.0rc2 (2026-10-20) predates themgpu=[...]with device names deploys onto whole pools, so workers can run on GPUs you didn't ask for. In a live test,["NVIDIA GeForce RTX 4090", "NVIDIA L4", "NVIDIA RTX A5000"]ran on anRTX PRO 6000 Blackwell Server Edition MIG 1g.24gbslice.Cause
gpu_ids_valuemaps each device to its pool and sends only the pool ids. The platform'sAMPERE_24pool also holds the RTX 3090 and the PRO 6000 MIG 24 GB slice. runpod-flash excluded the pool's other devices with-<device id>tokens, but only the ones in its static pool table. That table lacks the MIG slices, so Flash would land there too.Change
-<device id>. Pools named directly ("AMPERE_24") still allow all their devices.GET https://api.runpod.io/v2/catalog/gpus, thepoolfield), cached per process. Fall back to the static table, with a warning, when the catalog is unreachable. A failed lookup is retried after a minute.Testing
4090,L4,A5000)maingpuIdsADA_24,AMPERE_24-<device>for its static table onlyADA_24,AMPERE_24,-NVIDIA GeForce RTX 3090,-NVIDIA RTX PRO 6000 Blackwell Server Edition MIG 1g.24gbRTX PRO 6000 … MIG 1g.24gbNVIDIA GeForce RTX 4090How we tested and compared
torch.cuda.get_device_name()and was deployed withrp flash deployfrommainand then from this branch. We sent parallel jobs to force several workers and read the device name from each result.GET /v2/catalog/gpus,poolfield) puts the MIG slice inAMPERE_24, and neither static table lists it. That is why this PR reads pool membership from the live catalog.tests/test_apps/conftest.pykeeps the other tests offline.pytest tests: 1483 passed, coverage 91.67%.Review (Codex, two rounds)
AppsApiClient(api_key=...)