Repository navigation
Conversation
…eke/con-1119-rp-pod
…eke/con-1119-rp-pod
…eke/con-1119-rp-pod
…eke/con-1119-rp-pod
KAJdev
changed the base branch from
zeke/con-1118-rp-catalog
to
zeke/con-1155-rp-volume
October 20, 2026 00:56
KAJdev
added this pull request to stack #642
October 20, 2026 00:56
There was a problem hiding this comment.
🟡 Changes recommended
Restart readiness and log-stream handling have unresolved correctness issues.
5 open issues
What changed in this PR
Adds REST-backed pod lifecycle commands to rp, extending the resource-management work in #638.
Changes:
- Adds pod creation, updates, lifecycle actions, hardware selection, and JSON output.
- Integrates SSH access and shared log streaming with resumable cursors.
- Adds shared environment parsing and tests.
| File | Description |
|---|---|
| tests/test_cli/test_pod_command.py | Tests pod commands and REST-backed sync. |
| tests/test_cli/test_cli_options.py | Tests environment parsing. |
| tests/test_cli/test_cli_logs.py | Tests log snapshots and following. |
| tests/test_cli/test_cli_groups/test_ssh_functions.py | Tests REST SSH-key retrieval. |
| tests/test_apps/test_logs.py | Tests stream cursor handling. |
| runpod/rp_cli/pod.py | Implements pod lifecycle commands. |
| runpod/rp_cli/options.py | Adds shared environment parsing. |
| runpod/rp_cli/main.py | Registers the new pod command group. |
| runpod/rp_cli/logs.py | Adds shared CLI log views. |
| runpod/cli/groups/ssh/functions.py | Retrieves SSH keys through REST. |
| runpod/apps/logs.py | Adds REST stream selection and resume cursors. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds pod lifecycle commands with human-readable hardware selection, JSON output, and REST-backed SSH access. Builds on #638 and provides shared env parsing and SDK log streaming. Readiness waits use runtime uptime to reflect a running container.