Repository navigation
refactor: structure TypeScript error classes - #163
Open
adamcavendish wants to merge 1 commit into
Open
adamcavendish wants to merge 1 commit into
adamcavendish wants to merge 1 commit into
Conversation
- Emit generated error classes through TypeSpec, FieldSpec, and FunSpec while preserving ResponseError inheritance, readonly details, constructors, and response-header accessors. - Keep anonymous error-detail aliases unchanged until sigil-stitch supports inline object or record type names instead of adding a raw-source workaround. - Pin the structured class and header-method rendering and synchronize the resulting TypeScript golden layout without changing non-whitespace output.
adamcavendish
added this pull request to stack #162
October 23, 2026 16:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate generated TypeScript Fetch error classes from formatted declaration fragments to structural
TypeSpec,FieldSpec, andFunSpecemission.Problem
Error classes were still assembled as raw source alongside their detail aliases. That left inheritance, readonly fields, constructors, and response-header methods outside the structured sigil-stitch declaration pipeline.
Behavior
ResponseErrorinheritance, readonlydetail, constructor assignment, and default message are emitted structurally.Compatibility and boundaries
Cargo.lockchange, dependency patch, version bump, or release is included.