Skip to content

coalesce: Add missing attributes - #37

Merged
cathay4t merged 1 commit into
rust-netlink:mainfrom
ddaskala:coalesce-new-attrs
Oct 9, 2026
Merged

cathay4t merged 1 commit into
rust-netlink:mainfrom
ddaskala:coalesce-new-attrs

Conversation

@ddaskala

@ddaskala ddaskala commented Oct 1, 2026

Copy link
Copy Markdown

Several new attributes have been added to the ethtool coalesce netlink API. Update the code to properly display the new attributes.

Several new attributes have been added to the ethtool coalesce netlink
API. Update the code to properly display the new attributes.

Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
@ddaskala

ddaskala commented Oct 2, 2026

Copy link
Copy Markdown
Author

I tested this on 7.3.0-rc4 with a NIC that supports RxCqeNsecs.

# /tmp/dump_coalesce
EthtoolMessage { cmd: CoalesceGetReply, nlas: [Coalesce(Header([DevIndex(2), DevName("eth0")])), Coalesce(RxUsecs(33)), Coalesce(RxMaxFrames(88)), Coalesce(TxUsecs(66)), Coalesce(RxCqeNsecs(2000))] }

@ddaskala

ddaskala commented Oct 7, 2026

Copy link
Copy Markdown
Author

Hello @cathay4t, could you take a look when you have some time?

@cathay4t cathay4t left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathay4t

cathay4t commented Oct 9, 2026

Copy link
Copy Markdown
Member

Merged. Thanks for the contribution!

Sorry for missing the notification.

@cathay4t
cathay4t merged commit a38be5a into rust-netlink:main Oct 9, 2026
3 checks passed
@ddaskala
ddaskala deleted the coalesce-new-attrs branch October 9, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants