Skip to content

fix: 터미널 추가 영역 폭 축소 - #34

Merged
safethecode merged 1 commit into
mainfrom
fix/terminal-add-width
Oct 19, 2026
Merged

safethecode merged 1 commit into
mainfrom
fix/terminal-add-width

Conversation

@safethecode

@safethecode safethecode commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

세로 터미널 추가 영역이 너무 넓다는 사용자 피드백에 따라 폭을 80→48pt, 중앙 native plus를 56→32pt로 줄였습니다. 빈 터미널 칸 중앙의 56pt 버튼은 유지합니다.

검증: ./scripts/check.sh 전체36개 통과, 디자인 게이트 PASS. 별도 세션의 실제 AppKit 앱에서 라이트 격자 추가 클릭, 다크 탭/파일 트리 숨김, 643×434px 축소 창의 버튼 표시를 확인했습니다.

셀프 리뷰: 추가 순서·PTY·한도는 그대로이며, 모든 preset/두 모드/패널 개폐의 최소 크기 중앙 배치와 hitTest를 확인했습니다. 관찰 기록. 원래 실행 중인 앱의 작업은 종료하지 않았습니다.

Summary by CodeRabbit

  • UI Updates
    • Reduced the terminal add area’s height from 80pt to 48pt and its plus button from 56pt to 32pt, with 8pt side margins. The button remains centered, and the larger plus button in empty terminal cells is unchanged.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dee32dad-fa90-468e-835f-f2479e9867ea
📥 Commits

Reviewing files that changed from the base of the PR and between 6ad409c and 4b5bcc9.

📒 Files selected for processing: 8
  • DESIGN.md
  • Sources/Chop/TerminalAreaView.swift
  • Tests/ChopTests/WorkspaceGeometryTests.swift
  • design/evidence/terminal-add-width.md
  • design/failure-events.jsonl
  • design/gate-contract.json
  • design/gate-report.json
  • design/review.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The terminal add rail narrows from 80 to 48 points. Its centered plus control shrinks from 56×56 to 32×32 points. Geometry tests and design records are updated to reflect the dimensions.

Changes: Terminal Add Rail

Layer / File(s) Summary
Rail dimensions and geometry checks
Sources/Chop/TerminalAreaView.swift, Tests/ChopTests/WorkspaceGeometryTests.swift, DESIGN.md
The rail width changes to 48 points. The centered add button changes to 32×32 points, and the geometry test updates its expected size and hit-test point.
Design and verification records
design/evidence/terminal-add-width.md, design/gate-contract.json, design/gate-report.json, design/review.md
The records describe the updated rail and button dimensions, retain the 56-point empty-cell plus, and include verification evidence.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 4b5bc

This change narrows the terminal add area and its plus button. No actionable merge-blocking risk was found, and the code, test and documentation updates agree.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (5 skipped: 5 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: reducing the terminal add area width.
Description check Passed The description covers the problem, changed behavior, verification results, and self-review. It is mostly complete, although it does not use the required section headings and does not explicitly state…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, changed behavior, verification results, and self-review. It is mostly complete, although it does not use the required section headings and does not explicitly state remaining limitations.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (5 skipped: 5 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@safethecode
safethecode merged commit 4a1689b into main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant