Skip to content

fix: do not open listen events socket in webhook - #70164

Open
CrazyHackGUT wants to merge 2 commits into
saltstack:3008.xfrom
CrazyHackGUT:fix/mem-leak-webhook-engine
Open

fix: do not open listen events socket in webhook#70164
CrazyHackGUT wants to merge 2 commits into
saltstack:3008.xfrom
CrazyHackGUT:fix/mem-leak-webhook-engine

Conversation

@CrazyHackGUT

@CrazyHackGUT CrazyHackGUT commented Aug 27, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes a memory leak caused by using webhook engine by incorrect get_master_event parameters.

What issues does this PR fix or reference?

Memory leak in EventPublisher

Previous Behavior

get_master_event returns an object with opened pull-socket, which was not required for the publication of events, what causes memory leak in EventPublisher: EventPublisher sends a message for another process, but webhook doesn't even plan to read them.

New Behavior

get_master_event don't opens a pull-socket.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@CrazyHackGUT
CrazyHackGUT requested a review from a team as a code owner August 27, 2026 20:50
@welcome

welcome Bot commented Aug 27, 2026

Copy link
Copy Markdown

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We're glad you've joined our community and look forward to doing awesome things with you!

@twangboy
twangboy force-pushed the fix/mem-leak-webhook-engine branch from 5ee30c5 to b20da5a Compare August 28, 2026 00:10
@twangboy twangboy added the test:full Run the full test suite label Aug 28, 2026
@twangboy twangboy added this to the Argon v3008.3 milestone Aug 28, 2026

@twangboy twangboy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a changelog and a test for this

@CrazyHackGUT

Copy link
Copy Markdown
Author

Added a changelog entry (I used PR number as issue number)
Wrote simple test for testing this change, but I guess a test for the whole webhook for master + minion would be more appropriate here.

@CrazyHackGUT
CrazyHackGUT requested a review from twangboy August 28, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants