fix: do not open listen events socket in webhook - #70164
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
5ee30c5 to
b20da5a
Compare
twangboy
left a comment
There was a problem hiding this comment.
Please create a changelog and a test for this
|
Added a changelog entry (I used PR number as issue number) |
47d04e7 to
e70be0f
Compare
What does this PR do?
Fixes a memory leak caused by using
webhookengine by incorrectget_master_eventparameters.What issues does this PR fix or reference?
Memory leak in EventPublisher
Previous Behavior
get_master_eventreturns an object with openedpull-socket, which was not required for the publication of events, what causes memory leak inEventPublisher:EventPublishersends a message for another process, butwebhookdoesn't even plan to read them.New Behavior
get_master_eventdon't opens apull-socket.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No