Make "pass_num" name consistent across "mount" functions - #70173
Open
meaksh wants to merge 3 commits into
Open
Conversation
meaksh
force-pushed
the
master-unify-pass_num-arguments
branch
from
August 28, 2026 10:18
2f4d2bb to
97e6ef6
Compare
meaksh
force-pushed
the
master-unify-pass_num-arguments
branch
from
August 28, 2026 10:22
97e6ef6 to
f4d1b2e
Compare
Co-authored-by: Yeray Gutiérrez Cedrés <yeray.gutierrez@suse.com>
meaksh
force-pushed
the
master-unify-pass_num-arguments
branch
from
August 28, 2026 11:10
677af9e to
762adf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the
mountmodules to have a consistent naming for thepassargument, in favor ofpass_numonly. The namepassis not used as it created problem due reserved Python word.Before this PR, different
mountfunctions use different naming for the "pass" argument:pass_num,pass_fsckandfs_passno.Also the, the output for
mount.fstabandmount.vfstabusespassto identify this value.After this PR, all functions and output for
mountmodules will usepass_num, but we keep legacypassin the output during deprecation time until 3011.Also the PR adds deprecations warnings until Salt 3011 (2 major version ahead) to indicate the legacy argument names will be removed.
What issues does this PR fix or reference?
Fixes openSUSE/salt#668
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes