Remove deprecated salt.features module (removed in 3009 per warn_until gate) - #70183
Open
dwoz wants to merge 1 commit into
Open
Remove deprecated salt.features module (removed in 3009 per warn_until gate)#70183dwoz wants to merge 1 commit into
dwoz wants to merge 1 commit into
Conversation
…l gate)
The salt.features singleton (Features.get) has been on a warn_until(3009)
gate since 3007. Master builds toward 3009 (Potassium), so this is the
release that ships with the module gone.
Nothing in the tree still consumes it:
- The three real feature flags (x509_v2,
enable_deprecated_orchestration_flag,
enable_deprecated_module_search_path_priority) already read directly
from __opts__["features"] / opts.get("features", {}).
- The only in-tree callers of the singleton were the 5
salt.features.setup_features(opts) calls in salt/config/__init__.py
(populating a shim that no runtime code reads).
- No test references.
Changes:
- Delete salt/features.py.
- salt/config/__init__.py: drop the "import salt.features" and all
5 setup_features(opts) call sites.
- Add changelog fragment.
External users of "from salt.features import features" should migrate
to reading opts["features"] / __opts__["features"] directly:
if __opts__.get("features", {}).get("<flag>"):
...
dwoz
force-pushed
the
dwoz/removed/salt-features
branch
from
August 29, 2026 00:38
8ac8fbe to
1b463b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
salt.featuressingleton (Features.get) has been on awarn_until(3009, ...)gate since 3007. Master builds toward 3009 (Potassium), so this is the release that ships with the module gone.Nothing in the tree still consumes it:
x509_v2,enable_deprecated_orchestration_flag,enable_deprecated_module_search_path_priority) already read directly from__opts__["features"]/opts.get("features", {}).salt.features.setup_features(opts)calls insalt/config/__init__.py, populating a shim that no runtime code reads.Files changed
salt/features.py-- deleted.salt/config/__init__.py-- droppedimport salt.featuresand all 5setup_features(opts)call sites.changelog/*.removed.md-- added.Migration
External users of
from salt.features import featuresshould readopts["features"]/__opts__["features"]directly:Testing
Ran the following suites locally against this branch (Python 3.14 venv):
tests/pytests/unit/config-- 163 passed, 2 skippedtests/pytests/unit/loader-- 48 passed, 2 skippedtests/unit/modules/test_x509.py+tests/pytests/unit/modules/test_x509_v2.py-- 3 passed, 13 skippedtests/unit/states/test_x509.py-- 2 passed, 1 skippedtests/pytests/unit/states/saltmod-- 36 passedPre-commit clean on all changed files.