Repository navigation
feat: sync/async per model like Monid, remove health (0.3.3) - #67
Merged
Merged
Conversation
…th (0.3.3) - bridge: when the server answers running, wait locally (sandbase_run_get every 3s, MCP progress notifications) and return the finished result under the agent's request id. Long waits for Claude Code and Codex configured with a long tool timeout; bounded 50s run_get waits elsewhere. tools/call runs concurrently; notifications/cancelled and stdin close stop waits. - Codex config: tool_timeout_sec = 1800 + SANDBASE_LONG_TOOL_CALLS=1. - CLI run / runs get wait by default (--no-wait), print the run id on stderr, keep waiting through file transfer, drop stale running hints. - Remove the HEALTH column, Health line and Skill section 7b. - Skill/README updated; version 0.3.3.
Sync tools return results directly and async tools return a run id to poll, as the server now does. Revert the bridge's local waiting and concurrency, and the CLI's wait-by-default. Keep: health removal, -w waiting through file transfer, no stale running hints, run id on stderr when -w waits, Codex tool_timeout_sec for long sync calls. Skill 0.3.3 describes the two kinds.
liyangbing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow the model's sync/async like Monid, and remove the health metrics. Pairs with sandbaseai/sandbase-monorepo#1130 (server: sync models answer in the call; async models return a run id at once).
discover, Health line ininspect, Skill §7b.-wnever returns an empty result: while a finished media run is still copying its files,run -w/runs get -wkeep waiting instead of stopping with no output; a stale "still in progress" hint no longer survives completion; the run id is printed to stderr when waiting starts (so an agent whose shell times out can resume).tool_timeout_sec = 1800, so long sync calls are not cut by Codex's 60s default.run_id, pollsandbase_run_getevery 5–10 s, never re-run. README updated (and the stale www-fallback sentence removed).Tests
npm test: 175 tests, 174 pass, 1 skip. New: no health in discover/inspect;-wwaits through transfer, drops stale hints, prints the run id on stderr; Codex config carriestool_timeout_sec.run sandbase_bfl_flux_3_text_to_image -wprinted the run id on stderr and returned the finished image in 48s.