Repository navigation
fix(private-link-gcp): promote step headings to H3 so v2 parser counts steps (#2833) - #24253
Merged
Merged
Conversation
Contributor
Content (1)
Checked 9a8e9a4 • notify-only, does not block merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promote the five
## Step N:headings inprivate-link-gcpto### Step N:so the SAP tutorial v2 parser recognizes them as steps.Why
The v2 parser segments steps on H3 (
###) headings only. These steps were authored as H2 (##), so the tutorial parsed tostepCount: 0, failed therebuild-content.yml"Validate tutorials" step (Invalid 'stepCount' value: 0), never produced a Hugo page, and therefore never published to PROD — the page 404s on developers.sap.com.Verified locally: after the change,
composeTutorial()returns 5 steps (was 0). Only the five Step headings change; intro, frontmatter, and all other content are untouched.Fixes the PROD 404 tracked in sap-tutorials/tutorials-ims#2833.
This is one half of a mirrored pair. Companion PR (Contribution): https://github.com/sap-tutorials/Tutorials-Contribution/pull/42174