Repository navigation
Build release binaries on EL8 so packages run on every supported distro - #128
Open
mscasso-scanoss wants to merge 2 commits into
Open
mscasso-scanoss wants to merge 2 commits into
mscasso-scanoss wants to merge 2 commits into
Conversation
Release binaries were built on Ubuntu 22.04 (glibc 2.35), so scanoss required glibc 2.33/2.34: the .rpm could not be installed on RHEL/Rocky/Alma 8 (glibc 2.28) and the .deb not on Debian 11 (2.31). - Compile ldb and the engine in a rockylinux:8 container (glibc 2.28 baseline) and fail the release if the binary requires a newer glibc. - Package with package.sh directly: make prepare_*_package rebuilds on the runner. - Depend on libgcrypt20 >= 1.8.0 (Debian 11 ships 1.8.x; EL8 builds only need 1.8 symbols). - Allow manual runs (workflow_dispatch), which upload the packages as workflow artifacts instead of creating a release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…work Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release binaries are built on
ubuntu-22.04(glibc 2.35), so thescanossbinary requiresGLIBC_2.33/GLIBC_2.34:.rpmcan't be installed on RHEL/Rocky/Alma 8 (glibc 2.28):scanoss-5.4.25-1.x86_64.rpmrequireslibc.so.6(GLIBC_2.33)(64bit)andlibc.so.6(GLIBC_2.34)(64bit);.debcan't run on Debian 11 (glibc 2.31), and also declareslibgcrypt20 (>= 1.9.0)while Debian 11 ships 1.8.x.Changes
rockylinux:8container (glibc 2.28 baseline). The same binaries,.tar.gz,.deband.rpmthen work on every supported distro. Packaging still runs on the Ubuntu runner.scanossrequires glibc > 2.28. ldb (latest release, as before) is built and installed in the same container, since the engine links againstlibldb.so.package.shdirectly:make prepare_*_packagedepends onalland would rebuild on the runner, undoing the EL8 build..debdepends onlibgcrypt20 (>= 1.8.0): built on EL8 (libgcrypt 1.8.5) the binaries only need 1.8 symbols (GCRYPT_1.6).workflow_dispatch, added) upload the packages as workflow artifacts instead of creating a release, and the tarball name is file-safe for branch names.Package file names are unchanged, so nothing changes for consumers (e.g. the on-premise installer).
Testing
workflow_dispatchis new here, so the workflow can't be run from this branch before merging. Its build and packaging steps were run locally with the same commands (rockylinux:8 build, ubuntu:22.04 packaging):scanossrequires glibc 2.22.ldb -vandscanoss -vrun andlddresolves everything:Related: scanoss/on-premise#31.
🤖 Generated with Claude Code