Repository navigation
fix(governance): ignore released and missing-worktree leases in governed_clone_evidence (ticket-188) - #191
Conversation
…ned_clone_evidence (ticket-188)
There was a problem hiding this comment.
Validator approval after policy checks for exact head 3f21ca9aaa897544a447ef27220252ce53ed572b.
Ticket: ticket-188
Correlation ID: local-semcod-goal-pr-191-ticket-188
Model: gemini/gemini-3.8-flash
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Extends governed_clone_evidence to ignore leases marked as released (phase, state, or released_at) as well as stale leases referencing non-existent worktree paths (worktreePath, worktree, or resolved worktreeId). All required checks pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: b6501606c29523c878065a9eeb2cb110b8bd8df0...3f21ca9aaa897544a447ef27220252ce53ed572b
Change digest: 545490a36f0666303539dc9990fca7899001c23bc1b7abd0c5bf6c1f8d30630e
Score: 48/100 (M), estimated 54 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":132,"base_sha":"b6501606c29523c878065a9eeb2cb110b8bd8df0","binary_files":0,"categories":{"code":1,"configuration":1,"docs":2,"tests":1},"change_digest":"545490a36f0666303539dc9990fca7899001c23bc1b7abd0c5bf6c1f8d30630e","comparison":"b6501606c29523c878065a9eeb2cb110b8bd8df0...3f21ca9aaa897544a447ef27220252ce53ed572b","deletions":2,"file_count":5,"files":["goal/governance/delivery.py","project/TICKETS.md","project/ticket-188/README.md","project/ticket-188/intent.json","tests/test_governance_delivery.py"],"head_sha":"3f21ca9aaa897544a447ef27220252ce53ed572b","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":54,"within_budget":false},"impact":{"components":["goal","project","subactor","tests"],"files":["goal/governance/delivery.py","project/TICKETS.md","project/ticket-188/README.md","project/ticket-188/intent.json","subactor/leases","tests/test_governance_delivery.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":11,"name":"Implement goal","scope":["goal"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement subactor","scope":["subactor"]},{"estimated_minutes":11,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-188"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-188: fix(governance): ignore released and missing-worktree leases in governed_clone_evidence (ticket-188)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 54m</text></svg>DECISION D-188-1493
TICKET ticket-188
HEAD_SHA 3f21ca9aaa897544a447ef27220252ce53ed572b
CORRELATION_ID local-semcod-goal-pr-191-ticket-188
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.13)=PASS","governance / enforce=PASS","test (3.12)=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","test (3.12)","test (3.13)","governance / remote lifecycle","governance / enforce"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/goal","pull_request":191,"head_sha":"3f21ca9aaa897544a447ef27220252ce53ed572b","base_sha":"b6501606c29523c878065a9eeb2cb110b8bd8df0","diff_sha256":"1168da5fdfb8c0f9746e0c3b1bea94312894a1411e87e6e70a5b8840a0f4b7f0"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["goal/governance/delivery.py","project/TICKETS.md","project/ticket-188/README.md","project/ticket-188/intent.json","tests/test_governance_delivery.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"b6501606c29523c878065a9eeb2cb110b8bd8df0","head_sha":"3f21ca9aaa897544a447ef27220252ce53ed572b","change_digest":"545490a36f0666303539dc9990fca7899001c23bc1b7abd0c5bf6c1f8d30630e","score":48,"complexity":"M","estimated_minutes":54,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "gemini/gemini-3.8-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Closes ticket-188. Ignores released and missing-worktree .subactor/leases/*.json records in governed_clone_evidence.