Skip to content

fix(perf): wire unused performance and reporter parameters across redup (ticket-018) #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tom-sapletta-com merged 1 commit into from
Oct 17, 2026
Merged

fix(perf): wire unused performance and reporter parameters across redup (ticket-018) #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .governance/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
"lib/**",
"packages/**",
"test/**",
"tests/**"
"tests/**",
"benchmarks/**"
]
},
"governance": {
Expand Down Expand Up @@ -321,6 +322,7 @@
"project/TICKETS.md",
"project/ticket-*/**",
".governance/standard-adoption.json",
".governance/manifest.json",
"config/artifact-registry.json"
],
"repository": {
Expand Down
305 changes: 303 additions & 2 deletions .governance/standard-adoption.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,313 @@
"schema": "wellmanifest.standard-adoption/v1",
"mode": "audit",
"profile": "baseline",
"repositoryRole": "unclassified",
"repositoryRole": "baseline",
"updates": {
"enabled": true,
"trigger": "pre-commit",
"action": "prepare-and-abort",
"executor": "goal"
},
"adoptions": []
"adoptions": [
{
"id": "wellmanifest/docs",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S3",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/git-lifecycle",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S4",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S4",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/logs",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S3",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/merge",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S4",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S4",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/new-project",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S4",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S4",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/ticket-lifecycle",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S3",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/validation-attestation",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S4",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S4",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
},
{
"id": "wellmanifest/worktrees",
"version": "0.20.54",
"revision": "fa7972da8f6a28a0afe2914aacf46bee4a846943",
"model": "protected-conformance",
"level": "S3",
"artifacts": [
{
"target": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
],
"evidence": [
{
"level": "S0",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S1",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S2",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
},
{
"level": "S3",
"uri": ".governance/manifest.json",
"sha256": "fe9adb7140c4039dffb85092b2da33de29378235ecbce4a4d3887a3dbf57f16b"
}
]
}
]
}
3 changes: 2 additions & 1 deletion benchmarks/bench_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@

def generate_test_project(root: Path, num_files: int = 50, lines_per_file: int = 200):
"""Generate project with known duplicates for benchmarking."""
num_funcs = max(1, lines_per_file // 10)
for i in range(num_files):
funcs = []
for j in range(10):
for j in range(num_funcs):
funcs.append(f'''
def func_{j}(x_{j}, y_{j}):
"""Docstring for func_{j}."""
Expand Down
2 changes: 2 additions & 0 deletions project/TICKETS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,6 @@ New identities are reserved exclusively by project/new-ticket.sh.
| **ticket-014** | [`README.md`](./ticket-014/README.md) | - | - | - | - | - |
| **ticket-015** | [`README.md`](./ticket-015/README.md) | - | - | - | - | - |
| **ticket-016** | [`README.md`](./ticket-016/README.md) | - | - | - | - | - |
| **ticket-017** | [`README.md`](./ticket-017/README.md) | - | - | - | - | - |
| **ticket-018** | [`README.md`](./ticket-018/README.md) | - | - | - | - | - |
<!-- AUTO:TICKET_INDEX:END -->
25 changes: 25 additions & 0 deletions project/ticket-018/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Ticket 018: Wire unused performance and reporter parameters across redup core, CLI, and benchmarks

- **ID**: ticket-018
- **Owner**: gemini
- **Status**: IN_PROGRESS
- **Workflow state**: EDIT
- **Created**: 2026-10-17
- **Authorization**: SESSION_EXECUTION_AUTHORIZATION

## Goal and scope

Wire previously ignored optional parameters across reDUP scanner utilities, semantic intent profile duplicate detection, code2llm reporter functions, CLI compare path formatting, refactoring advisor match list building, and library benchmark project generation, and record Wellmanifest standard pack adoption evidence.

## Acceptance criteria

- [x] AC-01: `_preload_files` in `src/redup/core/scanner_utils.py` enforces `max_cache_mb` byte budget (`max_bytes = int(max_cache_mb * 1024 * 1024)` when `max_cache_mb and max_cache_mb > 0`).
- [x] AC-02: `_find_intent_profile_duplicates` in `src/redup/core/semantic.py` bounds returned matches to `[:top_k]` when `top_k and top_k > 0`.
- [x] AC-03: `to_code2llm_toon` and `to_code2llm_context` in `src/redup/reporters/code2llm_reporter.py` wire `classes_count`, `files_scanned`, and `total_lines`.
- [x] AC-04: `_short_path` in `src/redup/cli_app/compare_command.py`, `_build_match_list` in `src/redup/core/refactor_advisor.py`, and `generate_test_project` in `benchmarks/bench_libraries.py` wire their optional parameters (`max_parts`, `limit`, `lines_per_file`).
- [x] AC-05: `audit_repository` reports 0 `PERF-AUDIT-*` findings, `standard_pack_check.py` reports `findings=0`, pytest passes, and `governance-check.sh` reports `GOV-PASS`.

## Tracking boundary

This directory contains the minimal reviewed intent. Optional participant prose
and raw command logs are not required delivery output.
Loading
Loading