Skip to content

fix(collector): recognize fully clipped live-region text - #12

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/012-css-clipped-text
Sep 24, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/012-css-clipped-text

Conversation

@tom-sapletta-com

@tom-sapletta-com tom-sapletta-com commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

A screen-reader live region using clip-path: inset(50%) produced false TW-TEXT-CLIPPED findings during the C2004 audit because DOM Range still returned text rectangles. The collector now recognizes provably empty percentage inset shapes on the element and its ancestors, retains node/style evidence, and excludes the unpainted content from visual checks. Focused content that remains fully clipped blocks audit completeness.

Partial and unsupported shapes retain existing detection. Sixteen real-browser regressions cover live regions, actual overflow, shadow hosts and focus reveal; the reporting test covers the blocking gap.

Validation: hosted CI passed all 334 unit and 105 browser tests without failures or skips, including 16 new rendered clipping regressions. Pinned Docs validation and JavaScript syntax checks passed. Required checks are unit and browser; merge is handled by the independent Validator.

Closes #11. Unblocks source-bound revalidation of maskservice/c2004 PLF-2556; this PR does not claim application deployment.

@tom-sapletta-com
tom-sapletta-com marked this pull request as ready for review September 24, 2026 17:20

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head f121b9a5444f575a3ed442cb5677bd792d802b4d.

Ticket: ticket-012
Correlation ID: local-semcod-testwins-pr-12-ticket-012
Model: gemini/gemini-3.8-flash
Reviewed diff chunks: 2
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 2 diff chunk(s). The PR introduces detection for visually empty CSS clip-path insets to prevent false TW-TEXT-CLIPPED findings. However, testwins/collector.js contains a fatal runtime TypeError when evaluating elements with default or non-inset clip-path values (such as 'none'). | The changes properly account for fully clipped elements (such as clip-path: inset(50%)) across collector element capture, heuristic alignment, visual detector passes, and completeness reporting. Focused clipped controls are flagged as a blocking scope gap to prevent unobservable visual focus.
Advisory findings: In testwins/collector.js, const parts = match?.[1].split(/\s+round\s+/)[0].trim().split(/\s+/) || []; attempts to invoke .split(...) directly on match?.[1]. When match is null (e.g., when clipPath is 'none', which is the default for almost all elements), match?.[1] evaluates to undefined, throwing TypeError: Cannot read properties of undefined (reading 'split'). This should use optional chaining (e.g., match?.[1]?.split(...)) or verify match before accessing properties.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 9bd5bc8e27329de7db3e405256eed90a0a7b7948...f121b9a5444f575a3ed442cb5677bd792d802b4d
Change digest: 3f6523052b337969c2dfca91e2aefcfa7c1d8f813dc28ec9658081fefe772645
Score: 76/100 (L), estimated 102 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":171,"base_sha":"9bd5bc8e27329de7db3e405256eed90a0a7b7948","binary_files":0,"categories":{"code":4,"docs":2,"tests":2},"change_digest":"3f6523052b337969c2dfca91e2aefcfa7c1d8f813dc28ec9658081fefe772645","comparison":"9bd5bc8e27329de7db3e405256eed90a0a7b7948...f121b9a5444f575a3ed442cb5677bd792d802b4d","deletions":11,"file_count":8,"files":["gitignore","docs/information/ux-strategies.md","project/ticket-012/README.md","tests/test_css_clipping_browser.py","tests/test_fail_closed.py","testwins/collector.js","testwins/detectors.py","testwins/reporting.py"],"head_sha":"f121b9a5444f575a3ed442cb5677bd792d802b4d","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":4,"scope":5,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":102,"within_budget":false},"impact":{"components":["102","docs","maskservice","node","project","repository-root","tests","testwins"],"files":["102/105","docs/information/ux-strategies.md","gitignore","maskservice/c2004","node/style","project/ticket-012/README.md","tests/test_css_clipping_browser.py","tests/test_fail_closed.py","testwins/collector.js","testwins/detectors.py","testwins/reporting.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":76,"split":{"parts":[{"estimated_minutes":12,"name":"Implement 102","scope":["102"]},{"estimated_minutes":12,"name":"Implement docs","scope":["docs"]},{"estimated_minutes":12,"name":"Implement maskservice","scope":["maskservice"]},{"estimated_minutes":12,"name":"Implement node","scope":["node"]},{"estimated_minutes":12,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-012"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-012: fix(collector): recognize fully clipped live-region text</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 54,78 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 102m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-012-8483
TICKET ticket-012
HEAD_SHA f121b9a5444f575a3ed442cb5677bd792d802b4d
CORRELATION_ID local-semcod-testwins-pr-12-ticket-012
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["docker=SKIPPING","browser=PASS","browser=PASS","unit=PASS","unit=PASS"]
INPUT required_checks = ["unit","browser"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/testwins","pull_request":12,"head_sha":"f121b9a5444f575a3ed442cb5677bd792d802b4d","base_sha":"9bd5bc8e27329de7db3e405256eed90a0a7b7948","diff_sha256":"ff34adc0afa68c05265d47d3a754c9cc8b433a2322c5a77e0010f75f49c3e40d"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":[".gitignore","docs/information/ux-strategies.md","project/ticket-012/README.md","tests/test_css_clipping_browser.py","tests/test_fail_closed.py","testwins/collector.js","testwins/detectors.py","testwins/reporting.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"9bd5bc8e27329de7db3e405256eed90a0a7b7948","head_sha":"f121b9a5444f575a3ed442cb5677bd792d802b4d","change_digest":"3f6523052b337969c2dfca91e2aefcfa7c1d8f813dc28ec9658081fefe772645","score":76,"complexity":"L","estimated_minutes":102,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "gemini/gemini-3.8-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit a9c3ca6 into main Sep 24, 2026
6 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/012-css-clipped-text branch September 24, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect fully CSS-clipped screen-reader text in visual observations

1 participant