Repository navigation
ci: restrict workflow token to read-only contents - #149
Merged
Merged
Conversation
Add top-level permissions: contents: read to build.yml and publish.yml, resolving CodeQL actions/missing-workflow-permissions alerts. No behaviour change for consumers; the workflow token is now read-only. Refs #146 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
CodeQL
actions/missing-workflow-permissionsalerts #9 (publish.yml:16), #11 (build.yml:11), #12 (build.yml:64). Adds top-levelpermissions: contents: readtobuild.ymlandpublish.yml. Item C of #146 (no release).Permission requirement per step
CODECOV_TOKENsecret, no GITHUB_TOKEN grant neededbuild-and-publish-nugets.sh --parallel $NUGET_API_KEYSo no job needs more than contents: read; no job-level grants added. No id-token/packages/releases usage exists.
Caller/callee
release-please.ymlpublish job already grantscontents: readto the reusablepublish.yml, which now requests exactlycontents: read(callee cannot exceed caller): compatible. Tag-push trigger uses the top-level grant. release-please.yml and codeql.yml already declare permissions (unchanged). Secrets untouched.Evidence
actionlint v1.7.12 (go run): clean, exit 0. publish.yml cannot be exercised without a release; reasoned from the steps above. This PR's build.yml run is the live check.
Behaviour change: workflow token read-only; nothing else.
Refs #146
🤖 Generated with Claude Code