Repository navigation
test(core): run oversized-input tests in a child process - #150
Merged
Merged
Conversation
The ToSnakeCase (6M chars) and GetRandomItems (6M items) tests ran in the test host, so a stack-overflow regression killed the whole host instead of failing one test. They now re-invoke the test assembly with a scenario name in a child process and assert on exit code 0; a crash is reported as a test failure with the child's exit code and stderr. No library behaviour change. Refs #146 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
The ToSnakeCase (6M chars) and GetRandomItems (6M items) regression tests ran inside the test host, so a stack-overflow regression crashed the whole host. They now run in a child process (the test assembly re-invoked via
dotnet <assembly> <scenario>;GenerateProgramFile=falseplus a tinyMainthat is only used for child runs, vstest never calls it). The test asserts exit code 0 and reports exit code/stderr on failure; 120s timeout kills the child.Evidence
Red: library fix for #142 reverted locally (not committed,
git checkout 2eddfba^ -- StringExtensions.cs RandomItemsExtensions.cs):GetRandomItems_Should_Not_Overflow_The_Stack_When_Source_Is_Very_LargeFAIL: "Scenario 'getrandomitems' exited with code 134. Stack overflow. at RandomItemsExtensions.GetRandomItems"ToSnakeCase_Should_Not_Overflow_The_Stack_When_Input_Is_Very_LargeFAIL: "Scenario 'tosnakecase' exited with code 134. Stack overflow. at StringExtensions.ConvertCase"Failed: 2, Total: 2in ~0.5s.Green: fix restored,
dotnet test -f net9.0 --filter FullyQualifiedName~Core: 2153 passed. Both tests ~0.3s each.Behaviour change
None (tests only, no release).
Refs #146
🤖 Generated with Claude Code