Conversation
…o update tools and tests
…to all fromtimestamp
axf295
reviewed
Jul 29, 2026
axf295
left a comment
axf295
left a comment
Contributor
There was a problem hiding this comment.
There seems to be a mixture of Time, datetime and AstropydanticTime? can we consolidate to astropy Time?
axf295
approved these changes
Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update which moves all internal times to
datetime. One word of caution is SQLlite does not preserve timezone information, so you have to reattach that when you get adatetimefrom the database. Copilot was used to identify how to correctly de-index a column that's being replaced, otherwise all code written by me. Note this is a branch of a branch which originally was going to also replaceintIDs withUUIDs, that feature has been removed from this branch but there are still some commit messages mentioning it.