Allow minimal maps to default to generic discriminator - #33
Closed
msyriac wants to merge 1 commit into
Closed
Conversation
msyriac
marked this pull request as draft
September 30, 2025 02:09
Member
Author
|
I'll try to get this to work with multi-component maps before asking for a review. |
msyriac
marked this pull request as ready for review
September 30, 2025 02:36
Member
Author
|
If a (3,Ny,Nx) map is in the FITS, it already defaults to the IQU discriminator. All this PR does is allow generic (Ny,Nx) maps (a very common use case) to be loaded, at least until the discriminator system becomes a bit more flexible. So this should be good now. |
Member
|
Implemented elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an 'unknown' discriminator with color range [-1,1] that maps with minimal FITS headers will default to. This allows a broad class of maps to be opened without having to have their FITS headers edited.