Repository navigation
Conversation
amxson
force-pushed
the
fix/metta-skill-rules
branch
from
October 22, 2026 19:17
1aae65c to
d1044cd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing
mettacurrently leaves its NAL/PLN guidance available to the model after the skill itself has been removed.Move the MeTTa-specific NAL/PLN guidance into the
mettaskill description so the guidance follows the skill lifecycle automatically.getSkillRulesnow retains only the generic file-I/O guidance.Add regression coverage for the default, removed, and re-added states, restoring the original skill metadata after the lifecycle check.
Fixes #405.
How Has This Been Tested?
tests/src_skills.metta: passed natively and in a container (11 checks each).tests/test_src_providers.py: 27 passed.mettaskill description contains the NAL/PLN guidance while registered, disappears with the skill after removal, and returns after re-addition.git diff --check: passed.Checklist