Repository navigation
fix(wallpapers-ocs): set owner_id to the registered provider id - #6
Merged
mirkobrombin merged 1 commit intoOct 14, 2026
Merged
Conversation
WallpaperOcs.items() sets owner_id to the per-network name (for example "pling"), but the registered provider id is "ocs". import_card() calls provider_registry.lookup(item.owner_id), so every OCS import failed with "Wallpaper provider is not active". Assisted-by: Claude Code:claude-sonnet-5 AI-Scope: Root-caused the owner_id mismatch and wrote the one-line fix against a live desktop session.
Member
|
Good catch, one line and the cause is clear. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WallpaperOcs.items()setowner_idto the per-network name (e.g.pling), but the registered provider id isocs, soimport_card()failed every OCS import with "Wallpaper provider is not active".One line in
wallpapers-ocs/wallpapers_ocs.vala: set each item'sowner_idto the providerid. Split out of #4, which keeps only thechoices()fix.Verified: failure reproduced on a live desktop session; with this commit on current main the tree builds and the test suite passes (24/24). Not re-run against the live OCS service.
AI assistance: disclosed