Skip to content

feat(sensors): group the details popover into tabs - #7

Open
perlowja wants to merge 1 commit into
singularityos-lab:mainfrom
perlowja:pr/sensors-popover-tabs-20261014
Open

perlowja wants to merge 1 commit into
singularityos-lab:mainfrom
perlowja:pr/sensors-popover-tabs-20261014

Conversation

@perlowja

Copy link
Copy Markdown
Contributor

Follow-up to #2 and #5. The details popover stacks every category in one tall column. On a 16 inch panel it reaches the dock, and the lists are cut at six rows.

Rows are now grouped into tabs: CPU (temperatures and clocks), Processor (per-core usage), Memory & Storage, and Hardware (GPU, NPU, VPU, system, board, network). A tab with no rows is left out, and the selected tab is kept across the periodic refresh. Grouped/Ungrouped works inside each tab, and the column count from the display width is unchanged. The per-group row cap goes from 6 to 12 so a 12-core CPU is shown in full. The height cap stays as a safety net: monitor height minus the chip bottom, the dock and a gap, never below 240 px.

Uses Singularity.Widgets.SegmentedControl over a Gtk.Stack; no new dependency.

Build and tests on Debian forky: ninja builds all plugins; meson test 48 of 49 pass (spell-integration aborts in the container and is unrelated).

AI assistance: disclosed

The popover stacked every category in one tall column that reached the
dock on a 16 inch panel. Group the rows into CPU, Processor, Memory &
Storage and Hardware tabs with a SegmentedControl over a Gtk.Stack,
leave out empty tabs, and keep the selected tab across refreshes.

Raise the per-group row cap from 6 to 12 so a 12-core CPU is shown in
full, and cap the height at the space between the chip and the dock.

Assisted-by: Claude Code:claude-sonnet-5-5
AI-Scope: Wrote the tab grouping, the height cap and the section split, rebased onto the reworked popover layout; checked on hardware by the author.
@perlowja

Copy link
Copy Markdown
Contributor Author

@mirkobrombin for review when you have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant