fix(maps): let transformRequest own all OFM URL rewriting, drop manual TileJSON inline - #182
Merged
Merged
Conversation
…l TileJSON inline Inlining the TileJSON tiles array (without vector_layers, scheme, attribution, etc.) caused MapLibre to silently fail feature extraction from the tiles: bytes were received correctly (181 KB valid MVT confirmed by probe) but no features were rendered. The issue is that MapLibre needs the full TileJSON metadata to process vector tiles correctly. fetchResolvedStyle is now a pure fetch+parse — it returns the style JSON as-is with OFM URLs untouched. transformRequest handles all URL rewriting at request time for tiles, TileJSON, sprites and glyphs, which is its designed purpose. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | fcb6dba | Aug 08 2026, 08:59 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause (confirmed)
Probe confirmed tiles are valid: status 200,
application/vnd.mapbox-vector-tile, 181 KB, bytes1a f1 0f(valid protobuf MVT). Network was never the issue.The bug:
fetchResolvedStylemanually fetched the TileJSON and inlinedtiles: []into the style source — but WITHOUT the TileJSON'svector_layers,scheme,attribution, and other metadata. MapLibre needs the full TileJSON to correctly process vector tiles; without it, tiles were received but features were silently not extracted (blank map despite valid tile bytes).Fix
fetchResolvedStyleis now a pure fetch+parse with zero URL manipulation.transformRequest(already set up) handles all OFM URL rewriting at request time — tiles, TileJSON, sprites, glyphs — exactly as MapLibre's API intends.🤖 Generated with Claude Code