Add async client transport cleanup - #765
Open
jonathan343 wants to merge 1 commit into
Open
Conversation
Generate close and async context manager methods for clients, and add matching cleanup support to aiohttp and CRT transports. Preserve shared transports when copying operation configs to avoid duplicating sessions and connection pools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds deterministic resource cleanup to generated clients and HTTP transports. It also preserves the configured transport across operation-level config copies so clients reuse one session and connection pool.
Current State
Each operation deep copies the client config, including its transport. This can create temporary HTTP clients, sessions, and connection pools that are discarded without cleanup. Applications may see repeated
Unclosed client sessionandUnclosed connectorwarnings during shutdown.New Pattern
Generated clients and HTTP transports now support
close()and async context managers. Operation config copies retain the client-owned transport instead of copying it.Clients can also be closed manually:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.