Repository navigation
Add reference states for the Stable Neo-Hookean inverted-tetrahedra scene - #142
Closed
lililii124 wants to merge 2 commits into
Closed
lililii124 wants to merge 2 commits into
lililii124 wants to merge 2 commits into
Conversation
Signed-off-by: yz <3318283120@qq.com>
Contributor
|
Dear @lililii124, Thank you again for your valuable contribution. As noted in #6377 in SOFA, ChangeLog and regression should be removed from the diff. This PR can therefore be closed. We thank you though for your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to sofa-framework/sofa#6220.
This PR contains the marker and 100-frame reference generated for the inverted Stable Neo-Hookean example at dt=5e-5 with UniformMass totalMass=1.0.
The SOFA reviewers requested keeping this scene outside the state regression suite for now because of its behavior. The companion SOFA PR therefore no longer registers this scene, and these references are not currently required by that PR. They are retained here for future consideration.
The reference was generated with SOFA's native WriteState on Windows in double precision. Repeating CompareState reported zero error. The upstream Regression_test executable and cross-platform CI were not exercised.
Companion SOFA PR: sofa-framework/sofa#6377.
AI assistance was used for implementation, tests and validation.