Skip to content

[Core] Deprecate beginIntegration method in BaseMechanicalState and its visitor - #6362

Merged
fredroy merged 2 commits into
sofa-framework:masterfrom
alxbilger:deprecatebeginIntegration
Nov 5, 2026
Merged

fredroy merged 2 commits into
sofa-framework:masterfrom
alxbilger:deprecatebeginIntegration

Conversation

@alxbilger

Copy link
Copy Markdown
Contributor

beginIntegration is dead code. Its counterpart for the end of the integration (endIntegration) is still useful, but wrongly named... It is the object of a later PR.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 7, 2026
@bakpaul
bakpaul marked this pull request as draft October 8, 2026 08:02
@bakpaul
bakpaul marked this pull request as ready for review October 8, 2026 08:02
@bakpaul
bakpaul requested a review from hugtalbot October 16, 2026 10:07
@hugtalbot hugtalbot changed the title [Core] Deprecate beginIntegration method in BaseMechanicalState [Core] Deprecate beginIntegration method in BaseMechanicalState and its visitor Nov 4, 2026
@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 4, 2026
@fredroy
fredroy merged commit 6879466 into sofa-framework:master Nov 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants