Skip to content

[Scene] Remove buggy scene - #6375

Merged
hugtalbot merged 1 commit into
sofa-framework:masterfrom
alxbilger:removescene
Oct 15, 2026
Merged

hugtalbot merged 1 commit into
sofa-framework:masterfrom
alxbilger:removescene

Conversation

@alxbilger

Copy link
Copy Markdown
Contributor

This scene crashes in:

More specifically because of:

- m_mop->propagateDx(m_r1);
+ simulation::common::DifferentialOperations::pushforwardTangent(m_mappingGraph, *m_params, m_r1);

The first thing we can notice is that DeformableOnRigidFrameMapping has an input belonging to a different solver!

Why is it a problem?

EulerImplicitSolver creates a new Data in each state of its mapping graph. If one state is out of its mapping graph, the Data will not be created. It's the case for m_r1.

Why does it not crash with propagateDx ?

Because in propagateDx, the VecId is defaulted to core::vec_id::write_access::dx when the VecId is not found in the state. So, it does not crash because we access to the Data associated to dx. And it's a problem because we are supposed to access to m_r1...

Why not fixing the scene ?

It can be "fixed" by moving all the objects under the same solver. This is what is done in the similar scene DeformableOnRigidFrameMapping.scn. The scene I deleted is equivalent, but using constraints instead. But for some reasons, the object teleports at the first step. I don't know why...


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Oct 15, 2026
@hugtalbot
hugtalbot merged commit 8f6fe6c into sofa-framework:master Oct 15, 2026
10 of 12 checks passed
bakpaul pushed a commit to bakpaul/sofa that referenced this pull request Oct 29, 2026
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 4, 2026
@hugtalbot hugtalbot added this to the v26.12 milestone Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants