Repository navigation
[Scene] Remove buggy scene - #6375
Merged
Merged
Conversation
hugtalbot
approved these changes
Oct 15, 2026
bakpaul
pushed a commit
to bakpaul/sofa
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This scene crashes in:
More specifically because of:
The first thing we can notice is that
DeformableOnRigidFrameMappinghas an input belonging to a different solver!Why is it a problem?
EulerImplicitSolvercreates a new Data in each state of its mapping graph. If one state is out of its mapping graph, the Data will not be created. It's the case form_r1.Why does it not crash with
propagateDx?Because in
propagateDx, the VecId is defaulted tocore::vec_id::write_access::dxwhen the VecId is not found in the state. So, it does not crash because we access to the Data associated todx. And it's a problem because we are supposed to access tom_r1...Why not fixing the scene ?
It can be "fixed" by moving all the objects under the same solver. This is what is done in the similar scene
DeformableOnRigidFrameMapping.scn. The scene I deleted is equivalent, but using constraints instead. But for some reasons, the object teleports at the first step. I don't know why...By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if